Repository navigation
fix: clustercache GetKubernetesClient reuses one client per cluster - #710
Merged
gianlucam76 merged 1 commit intoOct 27, 2026
Merged
Conversation
Member
|
Thanks for this @serhiimazurok . The cost is real. I measured it on a kind management cluster with one managed cluster, with --v=6 on addon-controller and event-manager. In steady state, with all profiles Provisioned, each periodic collector makes 24 discovery calls per minute (GET /api and GET /apis) for 12 real calls. I'll run few more tests in addon-controller and event-manager (replacing libsveltos with your branch). After that we can merge this. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetKubernetesClient only caches the rest.Config and calls client.New every time. Every new client builds its own RESTMapper, so each call runs discovery again (/api + /apis). On a management cluster with a lot of CRDs that adds up fast, the classifier was doing it every 10s.
This caches the client per cluster and drops it whenever the rest.Config is dropped. The controller-runtime mapper reloads on NoMatch, so CRDs created later still work (added a test for it).
Tested with classifier v1.16.0 built on top of this, discovery calls from the report loop are gone.