Repository navigation
fix: Sign in again when the renewed OIDC ID token has expired - #198
Merged
gianlucam76 merged 1 commit intoOct 8, 2026
Merged
Conversation
With auth.oidc.tokenType set to id_token, the dashboard stores the ID token of every silent renewal. When the provider returns no ID token on a refresh, oidc-client-ts keeps the previous one. Once that one has expired, storing it makes every request fail with a 401 until the user signs in again by hand. When a renewed ID token has already expired, clear the stored token, remove the OIDC user (which stops further renewals) and go to the login page, which now shows "Your session has expired, please login again". The default access_token mode is not affected. A token whose expiry cannot be read (not a JWT, no exp claim) is stored as before. The unit tests of the expiry check use vitest, which main gets with the profile form change (projectsveltos#196). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With auth.oidc.tokenType set to id_token, the dashboard stores the ID token of every silent renewal. When the provider returns no ID token on a refresh, oidc-client-ts keeps the previous one. Once that one has expired, storing it makes every request fail with a 401 until the user signs in again by hand.
When a renewed ID token has already expired, clear the stored token, remove the OIDC user (which stops further renewals) and go to the login page, which now shows "Your session has expired, please login again".
The default access_token mode is not affected. A token whose expiry cannot be read (not a JWT, no exp claim) is stored as before.
The unit tests of the expiry check use vitest, which main gets with the profile form change (#196).