Skip to content

feat: Separate rate limits for management and managed clusters #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianlucam76 merged 1 commit into from
Nov 1, 2026
Merged

feat: Separate rate limits for management and managed clusters #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require (
github.com/onsi/ginkgo/v2 v2.33.1
github.com/onsi/gomega v1.44.0
github.com/pkg/errors v0.9.1
github.com/projectsveltos/libsveltos v1.17.0
github.com/projectsveltos/libsveltos v1.17.1-0.20261101135809-65798348bae6
github.com/prometheus/client_golang v1.25.0
github.com/spf13/pflag v1.0.10
github.com/yuin/gopher-lua v1.1.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,8 @@ github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/projectsveltos/libsveltos v1.17.0 h1:7oIvY+bg9oLRYm8wlyZypYVvCcMspYl/FT9VG8XvQG0=
github.com/projectsveltos/libsveltos v1.17.0/go.mod h1:dHJrl1V5/WrNda5wzxbHs2dlsvoV/FUlwK1TXy2X3pA=
github.com/projectsveltos/libsveltos v1.17.1-0.20261101135809-65798348bae6 h1:lwfrK/ZH9Ee2YAcEdbS0T18QMp/ea7BvEt967oKQnu4=
github.com/projectsveltos/libsveltos v1.17.1-0.20261101135809-65798348bae6/go.mod h1:dHJrl1V5/WrNda5wzxbHs2dlsvoV/FUlwK1TXy2X3pA=
github.com/projectsveltos/lua-utils/glua-json v0.0.0-20251212200258-2b3cdcb7c0f5 h1:khnc+994UszxZYu69J+R5FKiLA/Nk1JQj0EYAkwTWz0=
github.com/projectsveltos/lua-utils/glua-json v0.0.0-20251212200258-2b3cdcb7c0f5/go.mod h1:yVL8KQFa9tmcxgwl9nwIMtKgtmIVC1zaFRSCfOwYvPY=
github.com/projectsveltos/lua-utils/glua-runes v0.0.0-20251212200258-2b3cdcb7c0f5 h1:YbsebwRwTRhV8QacvEAdFqxcxHdeu7JTVtsBovbkgos=
Expand Down
39 changes: 30 additions & 9 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
_ "k8s.io/client-go/plugin/pkg/client/auth"
"k8s.io/client-go/rest"
cliflag "k8s.io/component-base/cli/flag"
"k8s.io/klog/v2"
clusterv1 "sigs.k8s.io/cluster-api/api/core/v1beta2"
Expand All @@ -53,6 +54,7 @@ import (

"github.com/projectsveltos/classifier/controllers"
libsveltosv1beta1 "github.com/projectsveltos/libsveltos/api/v1beta1"
"github.com/projectsveltos/libsveltos/lib/clusterproxy"
"github.com/projectsveltos/libsveltos/lib/crd"
"github.com/projectsveltos/libsveltos/lib/deployer"
logs "github.com/projectsveltos/libsveltos/lib/logsettings"
Expand All @@ -73,6 +75,8 @@ var (
managementClusterControlPlaneEndpoint string
restConfigQPS float32
restConfigBurst int
managedClusterQPS float32
managedClusterBurst int
webhookPort int
syncPeriod time.Duration
version string
Expand Down Expand Up @@ -113,9 +117,8 @@ func main() {

ctrlOptions := getCtrlOptions(scheme)

restConfig := ctrl.GetConfigOrDie()
restConfig.QPS = restConfigQPS
restConfig.Burst = restConfigBurst
restConfig := getRestConfig()
clusterproxy.SetRestConfigLimits(managedClusterQPS, managedClusterBurst)

mgr, err := ctrl.NewManager(restConfig, ctrlOptions)
if err != nil {
Expand Down Expand Up @@ -229,15 +232,25 @@ func initFlags(fs *pflag.FlagSet) {
fs.BoolVar(&enableNatsWatcher, "enable-nats-watcher", false,
"Enable NATS.io configuration watcher on sveltos-agents to listen for cloud events. Disabled by default.")

const defautlRestConfigQPS = 20
const defautlRestConfigQPS = 40
fs.Float32Var(&restConfigQPS, "kube-api-qps", defautlRestConfigQPS,
fmt.Sprintf("Maximum queries per second from the controller client to the Kubernetes API server. Defaults to %d",
defautlRestConfigQPS))
fmt.Sprintf("Maximum queries per second from the controller client to the management cluster Kubernetes API server. "+
"Defaults to %d", defautlRestConfigQPS))

const defaultRestConfigBurst = 30
const defaultRestConfigBurst = 120
fs.IntVar(&restConfigBurst, "kube-api-burst", defaultRestConfigBurst,
fmt.Sprintf("Maximum number of queries that should be allowed in one burst from the controller client to the Kubernetes API server. Default %d",
defaultRestConfigBurst))
fmt.Sprintf("Maximum number of queries that should be allowed in one burst from the controller client to the "+
"management cluster Kubernetes API server. Default %d", defaultRestConfigBurst))

const defaultManagedClusterRestConfigQPS = 20
fs.Float32Var(&managedClusterQPS, "managed-cluster-kube-api-qps", defaultManagedClusterRestConfigQPS,
fmt.Sprintf("Maximum queries per second from the controller client to the Kubernetes API server of each managed cluster. "+
"Defaults to %d", defaultManagedClusterRestConfigQPS))

const defaultManagedClusterRestConfigBurst = 60
fs.IntVar(&managedClusterBurst, "managed-cluster-kube-api-burst", defaultManagedClusterRestConfigBurst,
fmt.Sprintf("Maximum number of queries that should be allowed in one burst from the controller client to the "+
"Kubernetes API server of each managed cluster. Default %d", defaultManagedClusterRestConfigBurst))

const defaultWebhookPort = 9443
fs.IntVar(&webhookPort, "webhook-port", defaultWebhookPort,
Expand Down Expand Up @@ -425,6 +438,14 @@ func getDiagnosticsOptions() metricsserver.Options {
}
}

// getRestConfig returns the rest.Config for the management cluster, with the configured QPS and burst.
func getRestConfig() *rest.Config {
restConfig := ctrl.GetConfigOrDie()
restConfig.QPS = restConfigQPS
restConfig.Burst = restConfigBurst
return restConfig
}

func getCtrlOptions(scheme *runtime.Scheme) ctrl.Options {
return ctrl.Options{
Scheme: scheme,
Expand Down
Loading