Repository navigation
fix: Do not overwrite ClassifierReport spec when collecting reports in agentless mode - #532
Merged
Merged
Conversation
…n agentless mode In agentless mode sveltos-agent writes the ClassifierReport directly in the management cluster, so the report listed by the collection and the one in the management cluster are the same object. updateClassifierReport copied the listed Spec over the current one, with a fresh resourceVersion obtained by reading it again. When the agent had written Spec.Match since the report was listed, the stale value was written back. Nothing evaluates the Classifier again after that, so the cluster never got its labels. In agentless mode collection now only marks the current report Processed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In agentless mode sveltos-agent writes the ClassifierReport directly in the management cluster, so the report listed by the collection and the one in the management cluster are the same object. updateClassifierReport copied the listed Spec over the current one, with a fresh resourceVersion obtained by reading it again. When the agent had written Spec.Match since the report was listed, the stale value was written back. Nothing evaluates the Classifier again after that, so the cluster never got its labels.
In agentless mode collection now only marks the current report Processed.