Repository navigation
fix: Remove Classifier instances from pull mode clusters in agentless mode - #531
Merged
Merged
Conversation
… mode In agentless mode reconcileDelete skipped undeployClassifier altogether, assuming no Classifier instance is ever copied to a managed cluster. That holds for clusters in push mode only: clusters in pull mode always get a copy, which was never removed once the Classifier was deleted. reconcileDelete now always calls undeployClassifier. When sveltos-agent runs in the management cluster, undeployClassifier skips the clusters which are not in pull mode, as they have no Classifier instance (nor the CRD). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In agentless mode reconcileDelete skipped undeployClassifier altogether, assuming no Classifier instance is ever copied to a managed cluster. That holds for clusters in push mode only: clusters in pull mode always get a copy, which was never removed once the Classifier was deleted.
reconcileDelete now always calls undeployClassifier. When sveltos-agent runs in the management cluster, undeployClassifier skips the clusters which are not in pull mode, as they have no Classifier instance (nor the CRD).