Repository navigation
fix: Record per cluster Classifier removal in the ClassifierReport - #529
Merged
Merged
Conversation
undeployClassifier needed the cleanup of every cluster to complete within a single reconcile pass. Deployer results are consumed on read and, in pull mode, the ConfigurationGroup is deleted once the removal completes (a missing ConfigurationGroup is then treated as an error and a new Remove one is created), so with many Classifiers deleted at once the cleanup never converged. When a Classifier is removed from a cluster, set the DeploymentStatus of the ClassifierReport to Removed. Reports already in that state are skipped on the next pass. removeClassifier now returns whether the Classifier was removed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undeployClassifier needed the cleanup of every cluster to complete within a single reconcile pass. Deployer results are consumed on read and, in pull mode, the ConfigurationGroup is deleted once the removal completes (a missing ConfigurationGroup is then treated as an error and a new Remove one is created), so with many Classifiers deleted at once the cleanup never converged.
When a Classifier is removed from a cluster, set the DeploymentStatus of the ClassifierReport to Removed. Reports already in that state are skipped on the next pass. removeClassifier now returns whether the Classifier was removed.