Repository navigation
fix: Do not remove the Classifier when undeploying from the management cluster - #528
Merged
Merged
Conversation
…t cluster When the management cluster is registered as a managed cluster, the Classifier instance found there is the Classifier itself. Undeploying it deleted the Classifier from the handler, bypassing the cleanup of the other clusters. Skip the instance when it has the same UID as the Classifier in the management cluster. For the other clusters, remove the finalizer older sveltos-agent versions share with classifier-manager before deleting the instance, as sveltos-agent now uses its own finalizer and would not release it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the management cluster is registered as a managed cluster, the Classifier instance found there is the Classifier itself. Undeploying it deleted the Classifier from the handler, bypassing the cleanup of the other clusters.
Skip the instance when it has the same UID as the Classifier in the management cluster. For the other clusters, remove the finalizer older sveltos-agent versions share with classifier-manager before deleting the instance, as sveltos-agent now uses its own finalizer and would not release it.