Repository navigation
fix: Count a drift once when the ClusterSummary update conflicts - #2078
Merged
gianlucam76 merged 1 commit intoOct 31, 2026
Merged
Conversation
gianlucam76
force-pushed
the
fix-total-drifts-counted-once
branch
from
October 30, 2026 21:15
8285267 to
ca8a6f7
Compare
processResourceSummary called trackDrifts inside the RetryOnConflict closure, before the ClusterSummary status update. Every Conflict ran the closure again, so projectsveltos_total_drifts was incremented again for the same drift. Collect the drifted features in the closure and count them once the update has succeeded. Fixes projectsveltos#2075
gianlucam76
force-pushed
the
fix-total-drifts-counted-once
branch
from
October 30, 2026 21:25
ca8a6f7 to
0450dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processResourceSummary called trackDrifts inside the RetryOnConflict closure, before the ClusterSummary status update. Every Conflict ran the closure again, so projectsveltos_total_drifts was incremented again for the same drift.
Collect the drifted features in the closure and count them once the update has succeeded.
Fixes #2075