Repository navigation
Conversation
getFastDialer copies fastdialer.DefaultOptions into opts and sets opts.CacheType to Memory, but then passes the unmodified DefaultOptions to NewDialer, so the override never takes effect. The bug came from 7be22cc ("reuse fastdialer + bump go"), which moved this code out of DefaultReusePooledTransport. At that time the fastdialer default was Disk, so the shared dialer used a disk-backed DNS cache in the system temp directory. fastdialer switched its default to Memory in projectdiscovery/fastdialer@45d91b8, so with v0.5.24 the bug has no effect unless a program changes fastdialer.DefaultOptions. Pass opts, as 88ac9a4 ("set memory cache by default") did, and add a comment explaining why the override stays even though it now matches the fastdialer default. Add a regression test that sets the fastdialer default to Disk, builds a new shared dialer, and checks that nothing is written to the temp directory. Fixes #602 Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Closes #603 Signed-off-by: Dwi Siswanto <git@dw1.io>
Mzack9999
approved these changes
Oct 20, 2026
Mzack9999
deleted the
dwisiswant0/fix/apply-in-memory-DNS-cache-override-in-getFastDialer
branch
October 20, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getFastDialer copies fastdialer.DefaultOptions into opts and sets
opts.CacheType to Memory, but then passes the unmodified
DefaultOptions to NewDialer, so the override never takes effect.
The bug came from 7be22cc ("reuse fastdialer + bump go"), which moved
this code out of DefaultReusePooledTransport. At that time the
fastdialer default was Disk, so the shared dialer used a disk-backed
DNS cache in the system temp directory. fastdialer switched its
default to Memory in projectdiscovery/fastdialer@45d91b8, so with
v0.5.24 the bug has no effect unless a program changes
fastdialer.DefaultOptions.
Pass opts, as 88ac9a4 ("set memory cache by default") did, and add a
comment explaining why the override stays even though it now matches
the fastdialer default.
Add a regression test that sets the fastdialer default to Disk, builds
a new shared dialer, and checks that nothing is written to the temp
directory.
Fixes #602