Skip to content

bump zcrypto to fix darwin/arm64 build - #1089

Merged
Mzack9999 merged 1 commit into
devfrom
fix/1088-zcrypto-darwin-arm64
Oct 23, 2026
Merged

Mzack9999 merged 1 commit into
devfrom
fix/1088-zcrypto-darwin-arm64

Conversation

@dogancanbakir

@dogancanbakir dogancanbakir commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Fixes #1088

Bumps zcrypto to aa1de3126e87, which adds the missing no-cgo loadSystemRoots for darwin/arm64 in ct/x509. Same version nuclei dev uses.

Summary by CodeRabbit

  • Chores
    • Updated indirect Go module dependencies to newer versions.

@dogancanbakir dogancanbakir self-assigned this Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fa85099d-a903-45bd-89a2-0adfe4908eb5
📥 Commits

Reviewing files that changed from the base of the PR and between a1536fe and 9d29372.

⛔ Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing: 1
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Go module file updates the indirect dependencies github.com/weppos/publicsuffix-go and github.com/zmap/zcrypto to newer pseudo-versions.

Changes

Dependency updates

Layer / File(s) Summary
Update indirect dependency versions
go.mod
The indirect dependencies github.com/weppos/publicsuffix-go and github.com/zmap/zcrypto now use newer pseudo-versions.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 9d293

The dependency updates are scoped to the reported build-fix objective, with no merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: updating zcrypto to fix the darwin/arm64 build failure. It is concise and specific.
Linked Issues check Passed Issue #1088 requires the darwin/arm64 release build with CGO_ENABLED=0 to use the upstream zcrypto fix for undefined: loadSystemRoots. The PR updates github.com/zmap/zcrypto to aa1de3126e87, the…
Out of Scope Changes check Passed The whole-PR summary contains only two indirect dependency updates in go.mod: zcrypto and github.com/weppos/publicsuffix-go. The zcrypto update implements issue #1088. The publicsuffix update is a…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #1088 requires the darwin/arm64 release build with CGO_ENABLED=0 to use the upstream zcrypto fix for undefined: loadSystemRoots. The PR updates github.com/zmap/zcrypto to aa1de3126e87, the revision identified by the issue and the PR description as containing the no-cgo darwin/arm64 implementation. The whole-PR summary shows the dependency declaration change and no conflicting source change.

Full details: Out of Scope Changes check

Explanation

The whole-PR summary contains only two indirect dependency updates in go.mod: zcrypto and github.com/weppos/publicsuffix-go. The zcrypto update implements issue #1088. The publicsuffix update is an accompanying indirect dependency update, with no unrelated source or feature change shown. go.sum was excluded from review, so it was not used as evidence.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the module list,
Two newer versions join the twist.
The build notes change, the lines stay few,
A quiet update hops on through.
I nibble clover, then review.

Comment @coderabbitai help to get the list of available commands.

@Mzack9999
Mzack9999 merged commit 1b0eb58 into dev Oct 23, 2026
10 checks passed
@Mzack9999
Mzack9999 deleted the fix/1088-zcrypto-darwin-arm64 branch October 23, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

darwin/arm64 release build fails in zcrypto ct/x509

2 participants