Ensure that content in re-used widgets (timelines) gets properly set#921
Merged
kevinaboos merged 1 commit intoJun 10, 2026
Merged
Conversation
The timeline portallist in a room can frequently re-use a widget, so we need to make sure that ALL content that a widget might show gets properly populated/set such that no old content is displayed. Generally this is unlikely or impossible, but we might as well be sure. This includes: * Clear link previews on messages that can't have link previews, e.g., redacted, file, audio, video, location, other unsupported messages. * Hide the edited and TSP indicators * Don't show reactions on redacted messages * Rebuild the row of avatars for a read receipts when it visibly changes. * Space lobby loading spinner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeline portallist in a room can frequently re-use a widget, so we need to make sure that ALL content that a widget might show gets properly populated/set such that no old content is displayed.
Generally this is unlikely or impossible, but we might as well be sure. This includes: