Refactor all modals to unify them into one shared SmallModal widget#918
Merged
kevinaboos merged 2 commits intoJun 9, 2026
Merged
Conversation
This basically ensures that we have a consistent modal display size and layout for all modals in Robrix. WIthout this, they looked a bit unprofessional due to their inconsistencies. Now every smaller modal (which excludes the full-screen modals for event source and file uploads) looks the same, and offers a title, body, and buttons row. This also makes the modals easier to define, and ensures that their content is never cut off by app window or screen size limitations, both vertically and horizontally, and that scrolling always works as expected. As part of this, we've fixed modal-related bugs on the Makepad side as well, such as scrolling piercing thru a modal to the underlying view, and scrolling within a modal (or any other view) that has a Fit-max bound, and drag scrolling using your finger. See: <makepad/makepad#1117> Thanks to those makepad fixes, the bottom margins of all modals are now respected when the app window is too short for the modal to fit. Other fixes: * Reset the user profile sliding pane when a room is shown. * Fix vertical spacing of buttons in the TSP settings screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #911
This basically ensures that we have a consistent modal display size and layout for all modals in Robrix. WIthout this, they looked a bit unprofessional due to their inconsistencies.
Now every smaller modal (which excludes the full-screen modals for event source and file uploads) looks the same, and offers a title, body, and buttons row.
This also makes the modals easier to define, and ensures that their content is never cut off by app window or screen size limitations, both vertically and horizontally, and that scrolling always works as expected.
As part of this, we've fixed modal-related bugs on the Makepad side as well, such as scrolling piercing thru a modal to the underlying view, and scrolling within a modal (or any other view) that has a Fit-max bound, and drag scrolling using your finger.
See: makepad/makepad#1117
Thanks to those makepad fixes, the bottom margins of all modals are now respected when the app window is too short for the modal to fit.
Other fixes: