Restore code reverted by bad rebase#1102
Open
cpuguy83 wants to merge 1 commit into
Open
Conversation
b70e037 was originally based on a very old branch. A rebase was required and was not properly reviewed. Many important changes were accidentially reverted as part of the commit. This change brings those changes back. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores code that was accidentally reverted during a bad rebase of commit b70e0372. The changes primarily refactor a monolithic test into focused sub-tests, add new test coverage for gomod, cache management, and deb-specific features, and fix a missing DnfInstallWithConstraints option in RPM test dependency installation.
Changes:
- Refactors the large monolithic
containertest intest/linux_target_test.gointo focused sub-tests (build_steps,sources,artifacts,tests,container), adds atestLinuxSpechelper to reduce boilerplate, addstestDepsOnlyfor deps-only target testing, adds extensive new test coverage for gomod replace directives, cache key management, deb-specific features (dpkg debug, upgrades, excludes config), and corrects multiple test targets fromContainertoPackagewhere container-specific features aren't needed. - Fixes
targets/linux/rpm/distro/pkg.goby addingDnfInstallWithConstraints(opts)to test dependency installation and hoisting the progress group append before the closure. - Removes the obsolete
mariner2entry from the artifact capabilities test targets map and adds a missingscanner.Err()check.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/linux_target_test.go |
Major test refactoring: splits monolithic test into focused sub-tests, adds testLinuxSpec and testDepsOnly helpers, adds new gomod/cache/deb tests, corrects Container→Package targets, removes mariner2, adds scanner error check |
targets/linux/rpm/distro/pkg.go |
Adds DnfInstallWithConstraints(opts) to test dep install options, moves ProgressGroup append before the closure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b70e037 was originally based on a very old branch.
A rebase was required and was not properly reviewed. Many important changes were accidentially reverted as part of the commit.
This change brings those changes back.