ci: run Check on pushes to main - #3
Merged
Merged
Conversation
The workflow only triggered on pull_request, so nothing verified main itself. A merge could land untested if its PR run was stale, or if two PRs were each green alone but conflicted semantically once combined. Add a push trigger scoped to main. PR branches are unaffected, since push is limited to main and their runs still come from pull_request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ralyodio
marked this pull request as ready for review
August 3, 2026 23:16
ThreatCrush Security Scan11 finding(s) HIGH/CRITICAL: 11
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Checkonly triggers onpull_request, somainitself is never verified.A PR's run reflects its merge commit at the time it ran — if that run is
stale, or if two PRs are each green in isolation but interact badly once both
land, a broken
maingoes unnoticed until the next PR happens to catch it.The two commits currently at the tip of
main(#1 and #2) were green as PRsbut have never been built on the trunk.
Change
pull_request: branches: - main + push: + branches: + - mainpushis scoped tomainonly, so PR branches are unaffected — pushing to afeature branch still produces exactly one run, from
pull_request. Noduplicate runs.
Verification
The PR's own
pull_requestrun exercises the file. Thepushhalf can only beobserved after merge — expect a
Checkrun againstmainimmediately onlanding, which will also give the trunk its first real build.
Not included: a
concurrencygroup to cancel supersededmainruns on rapidsuccessive merges. Reasonable follow-up, but out of scope here.
🤖 Generated with Claude Code