Repository navigation
perf(ci): parallelize complete collector ShellCheck gate - #1440
Draft
proerror77 wants to merge 2 commits into
Draft
proerror77 wants to merge 2 commits into
proerror77 wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The verified main restore run spent 14:33 in Collector control contracts: 815 seconds in the shell-contract step, including 695 seconds of behavioral tests.
Bound ShellCheck to four concurrent source-aware groups. Seven groups cover the same 62 deployment scripts; 68 arguments retain shared source companions. An exact NUL-safe set comparison rejects missing or unexpected inputs. Complete syntax validation still precedes lint, and any worker failure fails the gate.
Adapt the source-companion layout from historical draft #1371. Retain main's recovery isolation and complete behavioral suite. New helper/config changes select the existing collector gate.
Issue relationship
Refs #1430
Refs #1371
Validation
Final head:
0d3234b01a95ed53d506871f75a2c0fc0919b4d6.The first head correctly failed SC1091 after losing source context. Grouping and its regression tests fix that failure; no diagnostic was suppressed.
The historical serial pre-suite phase was about 120s; this run measured 61s. Collector job time was 873s historically versus 796s here. These are observations across different runners, not a controlled speedup estimate. Unaffected Rust/Loop/full research jobs were not selected in this PR, so this does not establish the complete main pipeline's 15-minute target. A separately authorized merge and subsequent full warm measurement remain necessary.
Maintenance and runtime impact
Register added/removed scripts and changed source relationships in the group layout; stale membership fails closed. Four workers bound CI resource use. Production code, behavioral assertions, timeouts, required gates, security rules and permission settings are unchanged.
A future authorized merge triggers existing main CI and conditional publication admission. No merge, deployment or cloud resource operation was performed. This PR remains draft.