Repository navigation
ci: avoid production-length waits in retry fixtures - #1438
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The baseline-reader retry fixture spent about a minute waiting for production timers on every CI policy run. Use a test-local Ruby timer shim only for retry cases. Assert the requested 45-second timeout and 1/2-second backoff values. Trigger the real timeout after one second and retain the real process-group cancellation and dead-process assertion. Record backoff calls instead of sleeping.
All existing retry, rejection, pagination, identity and confidentiality cases remain. Production reader code, its 180-second total budget, workflows, selection and required gates are unchanged. The shim is created inside the fixture directory and scoped through RUBYOPT to its read_baseline calls. Ruby's timeout thread retains real timing.
Issue relationship
None
Validation
013b2e12ef6113fd19fbaf2179ca652de88cfaae.git diff --checkpassed. Diff review confirms no production or workflow changes.ubuntu-24.04version20261012.334.1: previous PR job 194 s total / 179 s policy step; base main job 166 s total / 152 s policy step.da5a897ea39316a84323b06c76f38ce0de933faaand same Ubuntu image: attempt 1 140 s total / 126 s policy step; attempt 2 116 s total / 101 s policy step. Both passed all existing checks. Retry segment: 7 s in attempt 1.Runtime impact and rollback
Test-only timing. No production timeout, retry policy, release behavior, or runtime changes. Existing automatic publication selection remains unchanged. Revert this commit to restore real waiting in the fixture.