Repository navigation
Fix link errors due to unimplemented image drawing methods. - #13
Merged
Merged
Conversation
The PApplet class declared `PApplet::image(PImage&, float, float)` and `PApplet::image(PImage&, float, float, float, float)`. But those were never implemented.
Contributor
|
You’re right, those two overloads were declared but never defined, so anything going through image(const PImage&) or the const pointer versions failed to link. I checked it against main and together with the Wayland PR, and it merges clean and every image call resolves now. The const_cast is fine since image() only touches its cache fields, though at some point I might make those mutable instead. Merging, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PApplet class declared
PApplet::image(PImage&, float, float)andPApplet::image(PImage&, float, float, float, float).But those were never implemented.
This fixes #11