Repository navigation
ci: run the checks in the repo's own job - #22
Closed
dennis-tra wants to merge 2 commits into
Closed
dennis-tra wants to merge 2 commits into
dennis-tra wants to merge 2 commits into
Conversation
just lint needs no installed tool, and CI uses the same versions.
The shared go.yml workflow is removed in version 2 of probe-lab/.github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
probe-lab/.github#8 removes the shared
go.ymlworkflow, because it carried the needs of single repos as inputs. This repo now has its owncheckjob inci.yml. The job sets up Go andjust, then runs the repo's recipes, the same ones a person runs.justfilepins gofumpt and staticcheck and runs themx withgo run, sojust lintneeds no installed tool and CI uses the same versions.image.yml@v2..github/dependabot.ymlkeeps the action versions current, because the check steps are no longer shared.The standard is in probe-lab/ai-commons#16.
How I checked it
just lint,just buildandjust testpass locally.ci.yml.Deploy
Merge after probe-lab/.github#8 is merged and tagged
v2. Before that, the image job cannot start.Nothing deploys. Terraform in probelab-infra sets the image tag of the parsec services.