Repository navigation
chore: bring repo up to ProbeLab standard - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Brings parsec up to the ProbeLab repository standard. One commit per item.
LICENSEfile, and the README said MIT. Reviewers: please confirm this is intended. The README license line now links the new file.AGENTS.mdfollows the template and holds repo facts only. It was already moved out ofCLAUDE.md; no other tool-specific instruction files exist.justfilegetslintandci(lint,build,test);testtakes extra arguments;formatalso runsgo fix. The existing recipes (build,docker, database, migrations) stay..gitignoreignores.env..env.examplelists every variable the code reads, with defaults and no secrets.push.ymlbecomesci.yml: the sharedgo.yml@v1andimage.yml@v1workflows plus a finalci-okjob. The image keeps the same ECR repository, role and tag (parsec-sha<commit>). The old workflow only tested on push tomain; pull requests now run lint and test too, and gofumpt and staticcheck are installed throughgo-tools.staticcheck.confturns off 5 checks for existing findings (SA1016, SA1019, SA1029, SA4009, U1000) sojust lintpasses without code changes. Fixing them is left for follow-up changes.Left out on purpose:
deploy.ymland no deploy job: parsec has no Deploy workflow today.CHANGELOG.md: the repo publishes no releases.probelab-telemetryrules. The README documents the current names. No Grafana dashboard link is in the README.go fix -diffshows pending changes (any,rangeloops);lintdoes not fail on them, and I did not apply them.How I checked it
just cipassed locally (go fix -diff, go vet, staticcheck, build, test). Staticcheck on this machine was built with an older Go thango.modneeds, so I ran it from a freshly installedhonnef.co/go/tools/cmd/staticcheck@latest(v0.8.2). Most packages have no tests; onlypkg/utilhas any.ci.ymlhas not run yet. Its result on this pull request is the first check. I did not runactionlint.Deploy
Nothing to deploy. After merge, add
ci-okas the required check in the branch rules ofmain. The oldPush docker imageworkflow no longer exists, so remove it from any rule that requires it.