fix(cli): make logout and update notices clearer - #317
Draft
AmanVarshney01 wants to merge 1 commit into
Draft
AmanVarshney01 wants to merge 1 commit into
AmanVarshney01 wants to merge 1 commit into
Conversation
Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ended: 1field and completed-work notice from humanprisma auth logoutoutput.--jsonstill returnsendedCountandworkspaceIds.prismapackage for updates and suggestprisma@latest, not@prisma/cli@latest.Terminal previews
Captured with Termcut from the actual CLI presentation and update-check code, using an in-memory demo session and a synthetic
9.0.0update. No real credentials were touched.Known npm install
Install method unknown
Verification
pnpm --filter @prisma/cli test: 1022 passed, 2 skippedpnpm typecheckandpnpm lint: passedpnpm --filter @prisma/cli test:e2e: 7 passed, 48 skipped without a test API token