The engine 0.6.1 transition is over: delete the conformance exceptions - #291
Merged
Merged
Conversation
Both families now peer engine 0.6.1 (composer-cli 0.23.0, orm-toolchain 8.0.0-rc.12, both pinned since rc.17), so the three transition exceptions name pins nothing installs any more. Conformance reports nothing on the release and dev channels with the list empty. The project ledger records how the config-file chain shipped and closes its stale entries: the transition in flight, the family path-resolution PRs waiting on an engine, and the defineConfig rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
commit: |
wmadden
approved these changes
Sep 27, 2026
This was referenced Sep 27, 2026
Close the prisma-cli-v8 project: lasting docs into docs/, every open ledger entry into an issue
#312
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a glance
The release checks in
packages/cli/scripts/conformance.tsrefuse to ship aprismawhose command families were built against a different engine than the one it ships. While engine 0.6.1 was new, the families could not peer it yet, so these three entries let that mismatch through. Both families have now released against 0.6.1:prisma8.0.0-rc.17@prisma/composer-cli@prisma/orm-toolchainSo the entries now describe installs that no longer happen. They have to go: an entry left in place would let a real two-engine install through the next time those exact versions meet.
Checked
pnpm check:conformancereports "5 subject(s) checked, nothing to report" on both the release channel and the dev channel (PUBLISH_CHANNEL=dev), with the list empty. The dev builds (composer-cli@0.23.0-dev.1,orm-toolchain@8.0.0-rc.12-dev.13) also peer 0.6.1.pnpm lintandpnpm typecheckpass.Also in this PR
The project ledger (
.drive/projects/prisma-cli-v8/deferred.md) closes three entries that were no longer true:configSchemadeclaration, which superseded ORM config paths resolve against the file that declared them orm#30128. It also records a check run from the publishedprisma8.0.0-rc.17: root and nested configs merge, paths resolve against the file that declares them, andprisma initin a subdirectory skips the root-level steps.defineConfigrename entry is marked fixed by Config files import definePrismaConfig, the engine's current name for the marker orm#30129.🤖 Generated with Claude Code