Skip to content

The engine 0.6.1 transition is over: delete the conformance exceptions - #291

Merged
wmadden merged 1 commit into
mainfrom
chore/engine-061-transition-closed
Sep 27, 2026
Merged

wmadden merged 1 commit into
mainfrom
chore/engine-061-transition-closed

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

At a glance

-      exceptions: [
-        { familyPackage: "@prisma/composer-cli",  familyPin: "0.4.0", shellPin: "0.6.1", … },
-        { familyPackage: "@prisma/composer-cli",  familyPin: "0.5.0", shellPin: "0.6.1", channel: "dev", … },
-        { familyPackage: "@prisma/orm-toolchain", familyPin: "0.4.0", shellPin: "0.6.1", … },
-      ],
+      exceptions: [],

The release checks in packages/cli/scripts/conformance.ts refuse to ship a prisma whose command families were built against a different engine than the one it ships. While engine 0.6.1 was new, the families could not peer it yet, so these three entries let that mismatch through. Both families have now released against 0.6.1:

Package Version pinned in prisma 8.0.0-rc.17 Engine it peers
@prisma/composer-cli 0.23.0 0.6.1
@prisma/orm-toolchain 8.0.0-rc.12 0.6.1

So the entries now describe installs that no longer happen. They have to go: an entry left in place would let a real two-engine install through the next time those exact versions meet.

Checked

pnpm check:conformance reports "5 subject(s) checked, nothing to report" on both the release channel and the dev channel (PUBLISH_CHANNEL=dev), with the list empty. The dev builds (composer-cli@0.23.0-dev.1, orm-toolchain@8.0.0-rc.12-dev.13) also peer 0.6.1. pnpm lint and pnpm typecheck pass.

Also in this PR

The project ledger (.drive/projects/prisma-cli-v8/deferred.md) closes three entries that were no longer true:

🤖 Generated with Claude Code

Both families now peer engine 0.6.1 (composer-cli 0.23.0, orm-toolchain
8.0.0-rc.12, both pinned since rc.17), so the three transition
exceptions name pins nothing installs any more. Conformance reports
nothing on the release and dev channels with the list empty.

The project ledger records how the config-file chain shipped and closes
its stale entries: the transition in flight, the family path-resolution
PRs waiting on an engine, and the defineConfig rename.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 20c5b22f-d383-41a5-b6cb-c4d0a8e41093

📥 Commits

Reviewing files that changed from the base of the PR and between a00dae7 and e3369f5.

📒 Files selected for processing (2)
  • .drive/projects/prisma-cli-v8/deferred.md
  • packages/cli/scripts/conformance.ts

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@291
npx https://pkg.pr.new/@prisma/cli-engine@291

commit: e3369f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants