State the real reasons the engine has no dev builds - #286
Conversation
The workflow and versioning.md said the engine has no dev builds because ADR 0004 forbids pre-releases. ADR 0004 says no such thing. The real reasons: the product CLI packages peer the engine at an exact release version, dev builds included, so a dev-stamped engine would make prisma@dev uninstallable; and CI makes every change to the engine's published contents bump its version, which publishes on merge, so a dev build would expose nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe workflow comment and versioning documentation now explain why the engine has no dev builds. The documentation cites exact-version peer dependencies and CI’s version-bump requirement. The dist-tag section refers readers to the lockstep explanation. No workflow step logic changed. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The review found no supported issue that materially threatens users or blocks merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
#240 said the engine has no dev builds because ADR 0004 forbids pre-releases. ADR 0004 says no such thing. This PR states the real reasons in
publish.ymlanddocs/oss/versioning.md:npm install prisma@devwould fail.It changes wording only. The behavior #240 introduced is unchanged, and its first run published nothing new: engine 0.6.1 was already on the registry and resolved.
🤖 Generated with Claude Code