Skip to content

State the real reasons the engine has no dev builds - #286

Merged
wmadden-electric merged 1 commit into
mainfrom
docs/engine-dev-channel-reasons
Sep 24, 2026
Merged

wmadden-electric merged 1 commit into
mainfrom
docs/engine-dev-channel-reasons

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

#240 said the engine has no dev builds because ADR 0004 forbids pre-releases. ADR 0004 says no such thing. This PR states the real reasons in publish.yml and docs/oss/versioning.md:

  • The product CLI packages peer the engine at an exact release version, and so do their dev builds. A dev-stamped engine would satisfy none of them, so npm install prisma@dev would fail.
  • A dev build would expose nothing. CI refuses any change to the engine's published contents that does not bump its version, and that merge publishes the new version.

It changes wording only. The behavior #240 introduced is unchanged, and its first run published nothing new: engine 0.6.1 was already on the registry and resolved.

🤖 Generated with Claude Code

The workflow and versioning.md said the engine has no dev builds because ADR 0004 forbids pre-releases. ADR 0004 says no such thing. The real reasons: the product CLI packages peer the engine at an exact release version, dev builds included, so a dev-stamped engine would make prisma@dev uninstallable; and CI makes every change to the engine's published contents bump its version, which publishes on merge, so a dev build would expose nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f797b013-4f52-4df6-a71e-d55c07800b21

📥 Commits

Reviewing files that changed from the base of the PR and between 07df7be and 9e0abb1.

📒 Files selected for processing (2)
  • .github/workflows/publish.yml
  • docs/oss/versioning.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Summary by CodeRabbit

  • Documentation
    • Updated the versioning guidance to clarify that the engine has no dev builds. Product CLI dev builds require an engine at an exact release version, and engine changes are released with a version bump.
    • Updated the publishing guidance to reflect the same engine versioning behavior.

Walkthrough

The workflow comment and versioning documentation now explain why the engine has no dev builds. The documentation cites exact-version peer dependencies and CI’s version-bump requirement. The dist-tag section refers readers to the lockstep explanation. No workflow step logic changed.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 9e0ab

The review found no supported issue that materially threatens users or blocks merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: correcting the documented reasons why the engine has no dev builds.
Description check ✅ Passed The description accurately explains the wording changes and their two stated reasons. It is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@286
npx https://pkg.pr.new/@prisma/cli-engine@286

commit: 9e0abb1

@wmadden-electric
wmadden-electric merged commit a663d05 into main Sep 24, 2026
16 checks passed
@wmadden-electric
wmadden-electric deleted the docs/engine-dev-channel-reasons branch September 24, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants