ci: the DCO app checks merge-queue commits, so remove the placeholder DCO workflow - #30419
Merged
Merged
Conversation
… DCO workflow .github/workflows/dco.yml ran only on merge_group and echoed a message, so the merge queue had a DCO result while the app only checked PRs. The DCO app now receives merge-queue events and posts DCO on queue commits, and the required check accepts only the app. The placeholder result was ignored and cost a runner per queue entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: prisma/orm/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
size-limit report 📦
|
@prisma/orm-extension-arktype-json
@prisma/orm-extension-middleware-cache
@prisma/orm-extension-paradedb
@prisma/orm-extension-pgvector
@prisma/orm-extension-postgis
@prisma/orm-extension-supabase
@prisma/orm-family-mongo
@prisma/orm-family-sql
@prisma/orm-framework
@prisma/orm-mongo
@prisma/orm-postgres
@prisma/orm-sqlite
@prisma/orm-target-mongo
@prisma/orm-target-postgres
@prisma/orm-target-sqlite
@prisma/orm-toolchain
commit: |
wmadden
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a glance
The merge-queue commits for #30392, #30397 and #30410 each carry two
DCOresults:After this PR only the app's result remains.
What this PR changes
.github/workflows/dco.yml.docs/oss/ci-pipeline.mdsays theDCOcheck comes from the DCO app, on PRs and on merge-queue commits.Why the placeholder existed, and why it can go
The DCO requires a
Signed-off-by:trailer on every commit. The DCO GitHub App enforces it by posting a check namedDCO. Until recently the app only ran on PRs, so a merge-queue commit never got aDCOresult and the queue stalled.dco.ymlfilled that gap: it ran onmerge_group, echoed a message, and passed without reading any commits.The app now handles merge-queue events: the org installation accepted its new "Merge queues" permission. The
mainruleset requiresDCOfrom the app only, so the placeholder's result no longer counts toward the merge. It only costs a runner for every queued PR.Tests
None; this is a workflow deletion. This PR's own trip through the merge queue shows the app's
DCOresult satisfying the requirement without the placeholder.🤖 Generated with Claude Code
Summary by CodeRabbit