Skip to content

ci: the DCO app checks merge-queue commits, so remove the placeholder DCO workflow - #30419

Merged
wmadden merged 1 commit into
mainfrom
ci/remove-dco-placeholder
Sep 25, 2026
Merged

wmadden merged 1 commit into
mainfrom
ci/remove-dco-placeholder

Conversation

@wmadden-electric

@wmadden-electric wmadden-electric commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

At a glance

The merge-queue commits for #30392, #30397 and #30410 each carry two DCO results:

DCO  dco             success   <- the DCO app; the ruleset requires this one
DCO  github-actions  success   <- .github/workflows/dco.yml; ignored

After this PR only the app's result remains.

What this PR changes

  1. Deletes .github/workflows/dco.yml.
  2. docs/oss/ci-pipeline.md says the DCO check comes from the DCO app, on PRs and on merge-queue commits.

Why the placeholder existed, and why it can go

The DCO requires a Signed-off-by: trailer on every commit. The DCO GitHub App enforces it by posting a check named DCO. Until recently the app only ran on PRs, so a merge-queue commit never got a DCO result and the queue stalled. dco.yml filled that gap: it ran on merge_group, echoed a message, and passed without reading any commits.

The app now handles merge-queue events: the org installation accepted its new "Merge queues" permission. The main ruleset requires DCO from the app only, so the placeholder's result no longer counts toward the merge. It only costs a runner for every queued PR.

Tests

None; this is a workflow deletion. This PR's own trip through the merge queue shows the app's DCO result satisfying the requirement without the placeholder.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified that the DCO app posts a separate check for pull requests and merge-queue commits.
  • Chores
    • Removed a redundant DCO workflow check; DCO sign-off checks continue to be posted by the DCO app.

… DCO workflow

.github/workflows/dco.yml ran only on merge_group and echoed a message, so the merge queue had a DCO result while the app only checked PRs. The DCO app now receives merge-queue events and posts DCO on queue commits, and the required check accepts only the app. The placeholder result was ignored and cost a runner per queue entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric
wmadden-electric requested a review from a team as a code owner September 25, 2026 10:25
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: prisma/orm/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 40a97295-81cb-4f37-ad3f-256cbf336758

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0a334 and f1d21b6.

📒 Files selected for processing (2)
  • .github/workflows/dco.yml
  • docs/oss/ci-pipeline.md
 ____________________________________
< Squash the bug, not the messenger. >
 ------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
postgres / no-emit 195.1 KB (0%)
postgres / emit 165.75 KB (0%)
mongo / no-emit 185.11 KB (0%)
mongo / emit 166.58 KB (0%)
cf-worker / no-emit 218.07 KB (0%)
cf-worker / emit 185.51 KB (0%)

@pkg-pr-new

pkg-pr-new Bot commented Sep 25, 2026

Copy link
Copy Markdown

Open in StackBlitz

@prisma/orm-extension-arktype-json

npm i https://pkg.pr.new/@prisma/orm-extension-arktype-json@30419

@prisma/orm-extension-middleware-cache

npm i https://pkg.pr.new/@prisma/orm-extension-middleware-cache@30419

@prisma/orm-extension-paradedb

npm i https://pkg.pr.new/@prisma/orm-extension-paradedb@30419

@prisma/orm-extension-pgvector

npm i https://pkg.pr.new/@prisma/orm-extension-pgvector@30419

@prisma/orm-extension-postgis

npm i https://pkg.pr.new/@prisma/orm-extension-postgis@30419

@prisma/orm-extension-supabase

npm i https://pkg.pr.new/@prisma/orm-extension-supabase@30419

@prisma/orm-family-mongo

npm i https://pkg.pr.new/@prisma/orm-family-mongo@30419

@prisma/orm-family-sql

npm i https://pkg.pr.new/@prisma/orm-family-sql@30419

@prisma/orm-framework

npm i https://pkg.pr.new/@prisma/orm-framework@30419

@prisma/orm-mongo

npm i https://pkg.pr.new/@prisma/orm-mongo@30419

@prisma/orm-postgres

npm i https://pkg.pr.new/@prisma/orm-postgres@30419

@prisma/orm-sqlite

npm i https://pkg.pr.new/@prisma/orm-sqlite@30419

@prisma/orm-target-mongo

npm i https://pkg.pr.new/@prisma/orm-target-mongo@30419

@prisma/orm-target-postgres

npm i https://pkg.pr.new/@prisma/orm-target-postgres@30419

@prisma/orm-target-sqlite

npm i https://pkg.pr.new/@prisma/orm-target-sqlite@30419

@prisma/orm-toolchain

npm i https://pkg.pr.new/@prisma/orm-toolchain@30419

commit: f1d21b6

@wmadden
wmadden merged commit f91862f into main Sep 25, 2026
24 of 25 checks passed
@wmadden
wmadden deleted the ci/remove-dco-placeholder branch September 25, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants