Skip to content

docs(qa): orm init findings F3 and F10 are resolved by cli-engine 0.6.1 - #30398

Closed
wmadden-electric wants to merge 1 commit into
mainfrom
claude/qa-report-f3-f10-resolved
Closed

wmadden-electric wants to merge 1 commit into
mainfrom
claude/qa-report-f3-f10-resolved

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

At a glance

The 2026-09-15 manual QA report for orm init on a Prisma 7 project had two open findings about the terminal:

# Before After
F3 ⚠ should fix ✅ resolved
F10 ⚠ should fix (pre-existing) ✅ resolved

What this PR changes

  • Marks F3 (--confirm ignored in a terminal) and F10 (process does not exit after "Done") as resolved in projects/orm-init-prisma7-detection/manual-qa-reports/2026-09-15-fable.md, with the fixing version and how the fix was re-verified here.
  • No code changes.

Why both are already fixed on main

Both findings were bugs in @prisma/cli-engine, the package that runs every ORM CLI command and owns its prompts. They were fixed in prisma/prisma-cli#283 and shipped as engine 0.6.1. This repo's CLI package already pins 0.6.1, so main has the fix without any change here.

F3: the engine only looked at --confirm values in non-interactive sessions. It now checks them first in every session, so a matching value grants the consent before any prompt is drawn.

F10: the engine waited for its stdin reader to close before returning, and Node's stdin cannot close while it is waiting for a keystroke. This repo's bin already releases stdin itself after the run, but it never got the chance because the engine never returned. The engine no longer waits.

Verification

Built this repo's CLI from main, unchanged, and drove the guided prisma orm init --skip-install under a pseudo-terminal through its four prompts, answering each once. It printed its result and exited on its own, twice in a row.

Alternatives considered

  • Add a stdin adapter to this repo's bin too, mirroring the one added to prisma-cli's bin. Written and tested, then dropped: the bin's existing process.stdin.unref() in src/bin.ts already does the job once the engine returns, as the verification above shows.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric
wmadden-electric requested a review from a team as a code owner September 24, 2026 18:06
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • projects/orm-init-prisma7-detection/manual-qa-reports/2026-09-15-fable.md is excluded by !projects/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: prisma/orm/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: 21a48075-9ac2-4161-8c73-942642aefb57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@prisma/orm-extension-arktype-json

npm i https://pkg.pr.new/@prisma/orm-extension-arktype-json@30398

@prisma/orm-extension-middleware-cache

npm i https://pkg.pr.new/@prisma/orm-extension-middleware-cache@30398

@prisma/orm-extension-paradedb

npm i https://pkg.pr.new/@prisma/orm-extension-paradedb@30398

@prisma/orm-extension-pgvector

npm i https://pkg.pr.new/@prisma/orm-extension-pgvector@30398

@prisma/orm-extension-postgis

npm i https://pkg.pr.new/@prisma/orm-extension-postgis@30398

@prisma/orm-extension-supabase

npm i https://pkg.pr.new/@prisma/orm-extension-supabase@30398

@prisma/orm-family-mongo

npm i https://pkg.pr.new/@prisma/orm-family-mongo@30398

@prisma/orm-family-sql

npm i https://pkg.pr.new/@prisma/orm-family-sql@30398

@prisma/orm-framework

npm i https://pkg.pr.new/@prisma/orm-framework@30398

@prisma/orm-mongo

npm i https://pkg.pr.new/@prisma/orm-mongo@30398

@prisma/orm-postgres

npm i https://pkg.pr.new/@prisma/orm-postgres@30398

@prisma/orm-sqlite

npm i https://pkg.pr.new/@prisma/orm-sqlite@30398

@prisma/orm-target-mongo

npm i https://pkg.pr.new/@prisma/orm-target-mongo@30398

@prisma/orm-target-postgres

npm i https://pkg.pr.new/@prisma/orm-target-postgres@30398

@prisma/orm-target-sqlite

npm i https://pkg.pr.new/@prisma/orm-target-sqlite@30398

@prisma/orm-toolchain

npm i https://pkg.pr.new/@prisma/orm-toolchain@30398

commit: 6a89ad1

@wmadden-electric
wmadden-electric deleted the claude/qa-report-f3-f10-resolved branch September 24, 2026 18:12
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
postgres / no-emit 194.93 KB (0%)
postgres / emit 165.58 KB (0%)
mongo / no-emit 110.52 KB (0%)
mongo / emit 92.01 KB (0%)
cf-worker / no-emit 218.07 KB (0%)
cf-worker / emit 185.51 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant