docs(qa): orm init findings F3 and F10 are resolved by cli-engine 0.6.1 - #30398
Closed
wmadden-electric wants to merge 1 commit into
Closed
wmadden-electric wants to merge 1 commit into
wmadden-electric wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: prisma/orm/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
@prisma/orm-extension-arktype-json
@prisma/orm-extension-middleware-cache
@prisma/orm-extension-paradedb
@prisma/orm-extension-pgvector
@prisma/orm-extension-postgis
@prisma/orm-extension-supabase
@prisma/orm-family-mongo
@prisma/orm-family-sql
@prisma/orm-framework
@prisma/orm-mongo
@prisma/orm-postgres
@prisma/orm-sqlite
@prisma/orm-target-mongo
@prisma/orm-target-postgres
@prisma/orm-target-sqlite
@prisma/orm-toolchain
commit: |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a glance
The 2026-09-15 manual QA report for
orm initon a Prisma 7 project had two open findings about the terminal:What this PR changes
--confirmignored in a terminal) and F10 (process does not exit after "Done") as resolved inprojects/orm-init-prisma7-detection/manual-qa-reports/2026-09-15-fable.md, with the fixing version and how the fix was re-verified here.Why both are already fixed on main
Both findings were bugs in
@prisma/cli-engine, the package that runs every ORM CLI command and owns its prompts. They were fixed in prisma/prisma-cli#283 and shipped as engine 0.6.1. This repo's CLI package already pins 0.6.1, so main has the fix without any change here.F3: the engine only looked at
--confirmvalues in non-interactive sessions. It now checks them first in every session, so a matching value grants the consent before any prompt is drawn.F10: the engine waited for its stdin reader to close before returning, and Node's stdin cannot close while it is waiting for a keystroke. This repo's bin already releases stdin itself after the run, but it never got the chance because the engine never returned. The engine no longer waits.
Verification
Built this repo's CLI from main, unchanged, and drove the guided
prisma orm init --skip-installunder a pseudo-terminal through its four prompts, answering each once. It printed its result and exited on its own, twice in a row.Alternatives considered
process.stdin.unref()insrc/bin.tsalready does the job once the engine returns, as the verification above shows.🤖 Generated with Claude Code