Skip to content

chore(drive): close the emulator-commands project - #372

Merged
wmadden-electric merged 3 commits into
mainfrom
chore/close-emulator-commands
Oct 21, 2026
Merged

wmadden-electric merged 3 commits into
mainfrom
chore/close-emulator-commands

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

At a glance

D  .drive/projects/emulator-commands/   (spec, plan, design notes, six slice specs, deferred list)
M  .drive/deferred.md                   (+ "Emulator commands — deferred at project close")

This closes the emulator-commands project. It deletes the project's planning files and moves the follow-ups it left open into the repo-wide deferred list.

What the project delivered

These commands ship in Composer 0.32.0 and prisma@8.0.0-rc.24:

  • prisma dev url <address> prints where a node of the local app answers.
  • prisma dev stop stops the app and keeps its data and ports.
  • prisma dev --detach returns once every service answers.
  • prisma emulator list shows every instance the machine's emulators hold.

The design is recorded in ADR-0052 (Composer maps its nodes to emulator instances per directory) and ADR-0053 (the commands). The user docs are docs/guides/running-locally.md, docs/design/10-domains/local-dev.md and the core-concepts skill. Nothing in the deleted files needs to move: the design notes' decisions are in those ADRs, and the specs and plan only coordinated the work.

Definition of done

Each item from the project spec, with its evidence:

Follow-ups

The project's open follow-ups now live in .drive/deferred.md, under "Emulator commands — deferred at project close". Two items were dropped because they were resolved: a held service's start race, and services that never listen (both fixed in #353). A third was dropped too: what a previous app's databases and buckets become, which was decided as "stopped and kept". One prisma-cli item was added: its agent-skills notice names @prisma/orm-postgres in projects that don't use it.

Retro

Lessons from the project, each already recorded where it applies:

  • A stopped instance first released its port, which broke restarts, because the port is baked into dependents' environment variables. ADR-0052 now says an instance keeps its port until it is deleted.
  • A change to dev stop's report made it skip instances that were still starting. A real-emulator test now fails if the stop is sent only to listed instances.
  • Test files picked clashing ports on CI. Each file now uses its own port range.
  • A fixed bot review left in "changes requested" blocked approved PRs. This is noted in the agent's merge procedure.

Alternatives considered

  • Keep the project directory as a record. The ADRs, guide and merged PRs already hold everything a later reader needs. The planning files would go stale.
  • Open GitHub issues for each follow-up. The repo keeps follow-ups from closed projects in .drive/deferred.md, so this follows that.

Agent: attila-51

🤖 Generated with Claude Code

Move its open follow-ups to .drive/deferred.md and delete
.drive/projects/emulator-commands/. The design lives in ADR-0052 and ADR-0053.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@prisma-gizmo

prisma-gizmo Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Caution

Gizmo failed to process the last GitHub event for this pull request: This suspended workflow run was already resumed by another caller. Workflow "guardrail-lifecycle" run "67a34152-6694-44ea-b41d-662f056c7579" moved from "suspended" to "running" before this resume could claim it. Only one resume() call may continue a given suspension; re-read the run state before resuming again.

Open findings: 🟡 1 minor

Change walkthrough

This PR closes the emulator-commands project: it deletes .drive/projects/emulator-commands/ (spec, plan, design notes, six slice specs, deferred list) and migrates the project's open follow-ups into the repo-wide .drive/deferred.md under a new "Emulator commands — deferred at project close (2026-10-21)" section, following the repo's convention of keeping follow-ups from closed projects in the central list rather than filing GitHub issues.

What shipped (recorded as done). The four commands — prisma dev url, prisma dev stop, prisma dev --detach, prisma emulator list — are marked delivered against real emulators, with the design captured in ADR-0052 (per-directory instance mapping) and ADR-0053 (the commands). The PR argues nothing needs migrating out of the deleted files: the design notes' decisions live in the ADRs, and the specs and plan only coordinated the work.

The deferred section. The new section carries the project's unresolved items forward — the delete-while-starting race, shared env.json/secrets.json, [dev] notices bypassing the CLI engine's output, missing dev url retry, data-line gaps for deploy/--detach/ORM commands, and the planned emulator start/stop project. Three items from the project's own deferred list were dropped as resolved (start-join crash-backoff race, services that never listen, and the fate of a previous app's databases/buckets), which the PR description accounts for.

Incremental delta. Since the last reviewed commit, the only change is a two-line parenthetical appended to the "ORM commands print nothing to a pipe" bullet at .drive/deferred.md:237-238, carving out contract print and contract emit as already writing their output to stdout.

One review-context note: git history beyond the diff was unreachable in this checkout, so claims pointing at merged PRs (composer #353–#368, prisma-cli #353/#355, web #8545) were taken as documented rather than re-verified.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 64b9925d-0b47-401b-8725-6a9e4df244d2
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@prisma-gizmo prisma-gizmo Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New findings: 🟡 1 minor · trace

Comment thread .drive/deferred.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>

@prisma-gizmo prisma-gizmo Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New findings: 🟡 1 minor · trace

Comment thread .drive/deferred.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric
wmadden-electric merged commit 58b48fe into main Oct 21, 2026
23 checks passed
@wmadden-electric
wmadden-electric deleted the chore/close-emulator-commands branch October 21, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants