Repository navigation
chore(drive): close the emulator-commands project - #372
Conversation
Move its open follow-ups to .drive/deferred.md and delete .drive/projects/emulator-commands/. The design lives in ADR-0052 and ADR-0053. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Caution Gizmo failed to process the last GitHub event for this pull request: This suspended workflow run was already resumed by another caller. Workflow "guardrail-lifecycle" run "67a34152-6694-44ea-b41d-662f056c7579" moved from "suspended" to "running" before this resume could claim it. Only one resume() call may continue a given suspension; re-read the run state before resuming again. Open findings: 🟡 1 minor Change walkthroughThis PR closes the emulator-commands project: it deletes What shipped (recorded as done). The four commands — The deferred section. The new section carries the project's unresolved items forward — the delete-while-starting race, shared Incremental delta. Since the last reviewed commit, the only change is a two-line parenthetical appended to the "ORM commands print nothing to a pipe" bullet at .drive/deferred.md:237-238, carving out One review-context note: git history beyond the diff was unreachable in this checkout, so claims pointing at merged PRs (composer #353–#368, prisma-cli #353/#355, web #8545) were taken as documented rather than re-verified. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
At a glance
This closes the emulator-commands project. It deletes the project's planning files and moves the follow-ups it left open into the repo-wide deferred list.
What the project delivered
These commands ship in Composer 0.32.0 and
prisma@8.0.0-rc.24:prisma dev url <address>prints where a node of the local app answers.prisma dev stopstops the app and keeps its data and ports.prisma dev --detachreturns once every service answers.prisma emulator listshows every instance the machine's emulators hold.The design is recorded in ADR-0052 (Composer maps its nodes to emulator instances per directory) and ADR-0053 (the commands). The user docs are
docs/guides/running-locally.md,docs/design/10-domains/local-dev.mdand the core-concepts skill. Nothing in the deleted files needs to move: the design notes' decisions are in those ADRs, and the specs and plan only coordinated the work.Definition of done
Each item from the project spec, with its evidence:
curl "$(npx prisma dev url gateway)"from the published binary. Met. The page was followed as written againstprisma@8.0.0-rc.24(docs: Composer pages ask prisma dev url for local URLs, and the CLI reference covers dev url, dev stop, --detach and emulator list web#8545). The spec'sjqpipe was dropped when the CLI started giving a pipe plain data (feat!: piping a prisma command gives its plain data; JSON needs --json prisma-cli#353).emulator listlabels each with its directory.dev stopafter akill -9, nothing of the app runs, and the nextprisma devgets the same ports. Met (feat(dev): checkouts of one app get their own local databases and buckets, and prisma dev stops its Postgres servers on exit #356, fix(dev): prisma dev stop reports only what it stopped, and dev and deploy flag help says what each flag does #368). This was checked against real emulators, including a stop while a service is still starting.emulator listshows services, databases and buckets with their directory and address. Met (feat(dev): checkouts of one app get their own local databases and buckets, and prisma dev stops its Postgres servers on exit #356, fix: emulator list writes data lines to a pipe, and dev url's docs use the bare URL #365).DEV.*codes.prisma dev url. Met (docs: Composer pages ask prisma dev url for local URLs, and the CLI reference covers dev url, dev stop, --detach and emulator list web#8545).Follow-ups
The project's open follow-ups now live in
.drive/deferred.md, under "Emulator commands — deferred at project close". Two items were dropped because they were resolved: a held service's start race, and services that never listen (both fixed in #353). A third was dropped too: what a previous app's databases and buckets become, which was decided as "stopped and kept". One prisma-cli item was added: its agent-skills notice names@prisma/orm-postgresin projects that don't use it.Retro
Lessons from the project, each already recorded where it applies:
dev stop's report made it skip instances that were still starting. A real-emulator test now fails if the stop is sent only to listed instances.Alternatives considered
.drive/deferred.md, so this follows that.Agent: attila-51
🤖 Generated with Claude Code