Conversation
Allow MIDI mixer LEDs to pulse from live audio peaks instead of only mirroring fader/button state. Users can set Music Reactive mode, adjust intensity, and keep using the existing custom Note/CC output assignment. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Make peak-meter activation and application peak aggregation explicit so Windows builds no longer hit E0277/E0631 during cargo tauri dev. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Use a closure for ProfileSnapshot deref coercion and look up device peaks with &str keys so Windows cargo tauri dev builds cleanly. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Let users flash the configured Note/CC/Pitch Bend address from the binding config panel so they can verify LED mapping before relying on music-reactive feedback. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Send camelCase deviceId/msgType to test_midi_feedback_output, and move the Test LED row out of the tight feedback mapping grid so the button and Save footer no longer collapse. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
overflow:hidden on the fader feedback section zeroed its grid min-size and hid Type/Channel/Control and Test LED once the intensity row appeared. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Stop the fader layout from shrinking under taller LED controls, scroll the body instead, and give the Cancel/Save bar a solid background. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Redesign intensity as a nonlinear sensitivity curve with adaptive baseline punch so mid-metering levels still flash when the slider is raised, and rename Music Reactive to Audio Reactive in the UI. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
Bring Audio Reactive LED mode, sensitivity response, Test LED helper, and related config-panel fixes onto main. Co-authored-by: Pezbino <Pezbino@users.noreply.github.com>
jrlpez
changed the title
prgmitchell
added a commit
that referenced
this pull request
Sep 28, 2026
Add Follow Value and Audio Reactive LED feedback from Windows and Wave Link meters while preserving existing feedback defaults and motor output. Support Mackie Control channel meters through automatic mappings or explicit strips. Keep meter samples separate from logical values, aggregate the loudest target, and refresh held Mackie levels. Fit the LED controls below Live without raising the minimum window height, and update localization and plugin documentation. Validate 77 frontend suites, 359 Rust tests, 96 layout cases, lint, architecture, localization, and bundled plugins. Physical X-Touch verification remains with testers using the signed test installer. Inspired by @jrlpez’s audio-reactive feedback proposal in #34; independently implemented. #34
Owner
|
closing this, implemented myself and credited in the commit. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified/added the LED control for each fader to allow for the Audio Reactive feature I previously requested. This addition allows the LED of the midi device react to the audio its controlling.
In this feature I have allowed the user to select a drop to either use the follow value which was the previous feature or the new audio reactive feature. I also implemented a test button so a user can easily check if the MIDIMaster system is correctly controlling that LED without having to save the change everytime.
Would recommend looking at the UI and making changes to make this best suit. I did do some small changes to fix it however it has caused the Live preview slider to look a little off.