Skip to content

Rotate idempotency key when we've gotten a 40x error on upload #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbi5 merged 3 commits into from
Oct 12, 2026
Merged

Rotate idempotency key when we've gotten a 40x error on upload #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c7b98a
Rotate idempotency key when gotten a 40x error on upload
robbi5 Oct 8, 2026
38ea257
Rotate idempotency key for order upload on 40x error too
robbi5 Oct 8, 2026
7afc9ec
For queued calls, update idempotency key on more 40x errors
robbi5 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 40 additions & 16 deletions libpretixsync/src/main/java/eu/pretix/libpretixsync/sync/SyncManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package eu.pretix.libpretixsync.sync;

import eu.pretix.libpretixsync.api.*;
import eu.pretix.libpretixsync.db.NonceGenerator;
import eu.pretix.libpretixsync.models.Question;
import eu.pretix.libpretixsync.models.db.QuestionExtensionsKt;
import eu.pretix.libpretixsync.sqldelight.Closing;
Expand Down Expand Up @@ -526,10 +527,12 @@ protected void uploadQueuedCalls(ProgressFeedback feedback) throws SyncException
call.getIdempotency_key()
);
if (response.getResponse().code() < 500) {
db.getQueuedCallQueries().delete(call.getId());
if (response.getResponse().code() >= 400) {
sentry.captureException(new ApiException("Received response (" + response.getResponse().code() + ") for queued call: " + response.getData().toString()));
// We ignore 400s, because we can't do something about them
db.getQueuedCallQueries().updateIdempotencyKey(NonceGenerator.nextNonce(), call.getId());

@robbi5 robbi5 Oct 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure about that one. postResource should throw some Exception, so that whole if shouldn't really be executed.

} else {
db.getQueuedCallQueries().delete(call.getId());
}
} else {
throw new SyncException(response.getData().toString());
Expand All @@ -547,6 +550,15 @@ protected void uploadQueuedCalls(ProgressFeedback feedback) throws SyncException
}
} catch (ApiException e) {
sentry.addBreadcrumb("sync.queue", "API Error: " + e.getMessage());
if (e instanceof DeviceAccessRevokedException // 401
|| e instanceof UnauthorizedApiException // 401
|| e instanceof PermissionDeniedApiException // 403
|| e instanceof NotFoundApiException // 404
|| e instanceof FinalApiException // >= 405
|| e instanceof ConflictApiException // 409
) {
db.getQueuedCallQueries().updateIdempotencyKey(NonceGenerator.nextNonce(), call.getId());
}
throw new SyncException(e.getMessage());
}
}
Expand Down Expand Up @@ -615,9 +627,9 @@ protected void uploadOrders(ProgressFeedback feedback) throws SyncException {

List<QueuedOrder> orders = db.getQueuedOrderQueries().selectUnlockedWithoutError().executeAsList();

try {
int i = 0;
for (QueuedOrder qo : orders) {
int i = 0;
for (QueuedOrder qo : orders) {
try {
if (feedback != null && i % 10 == 0) {
feedback.postFeedback("Uploading orders (" + i + "/" + orders.size() + ") …");
}
Expand All @@ -641,19 +653,31 @@ protected void uploadOrders(ProgressFeedback feedback) throws SyncException {
// TODO: User feedback or log in some way?
db.getQueuedOrderQueries().updateError(resp.getData().toString(), qo.getId());
}
if (resp.getResponse().code() >= 400 && resp.getResponse().code() <= 500) {
db.getQueuedOrderQueries().updateIdempotencyKey(NonceGenerator.nextNonce(), qo.getId());
}
} catch (JSONException e) {
if (connectivityFeedback != null) {
connectivityFeedback.recordError();
}
sentry.captureException(e);
throw new SyncException("Unknown server response: " + e.getMessage());
} catch (ApiException e) {
if (connectivityFeedback != null) {
connectivityFeedback.recordError();
}
sentry.addBreadcrumb("sync.queue", "API Error: " + e.getMessage());
if (e instanceof DeviceAccessRevokedException // 401
|| e instanceof UnauthorizedApiException // 401
|| e instanceof PermissionDeniedApiException // 403
|| e instanceof NotFoundApiException // 404
|| e instanceof FinalApiException // >= 405
|| e instanceof ConflictApiException // 409
) {
db.getQueuedOrderQueries().updateIdempotencyKey(NonceGenerator.nextNonce(), qo.getId());
}
throw new SyncException(e.getMessage());
}
} catch (JSONException e) {
if (connectivityFeedback != null) {
connectivityFeedback.recordError();
}
sentry.captureException(e);
throw new SyncException("Unknown server response: " + e.getMessage());
} catch (ApiException e) {
if (connectivityFeedback != null) {
connectivityFeedback.recordError();
}
sentry.addBreadcrumb("sync.queue", "API Error: " + e.getMessage());
throw new SyncException(e.getMessage());
}

sentry.addBreadcrumb("sync.queue", "Receipt upload complete");
Expand Down
6 changes: 6 additions & 0 deletions libpretixsync/src/main/sqldelight/common/eu/pretix/libpretixsync/sqldelight/QueuedCall.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ VALUES (
?,
?
);

updateIdempotencyKey:
UPDATE QueuedCall
SET
idempotency_key = ?
WHERE id = ?;
6 changes: 6 additions & 0 deletions libpretixsync/src/main/sqldelight/common/eu/pretix/libpretixsync/sqldelight/QueuedOrder.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,9 @@ UPDATE QueuedOrder
SET
error = ?
WHERE id = ?;

updateIdempotencyKey:
UPDATE QueuedOrder
SET
idempotency_key = ?
WHERE id = ?;
Loading