Improve speed of logging methods with an additional "f" suffix#116
Open
XSven wants to merge 3 commits intopreaction:masterfrom
Open
Improve speed of logging methods with an additional "f" suffix#116XSven wants to merge 3 commits intopreaction:masterfrom
XSven wants to merge 3 commits intopreaction:masterfrom
Conversation
Owner
|
Thanks! This looks good as-is, though I think the conditional inside the sub that checks if it's a formatter could be skipped if instead the sub was built via string If you'd like I can merge this as-is and we can leave micro-optimization as a todo. I'll do that Sunday, April 26 unless you tell me otherwise :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have removed one level of subroutine calls. Maybe related to #69