Code-review fixes: fail-fast env install + harden skill-linking

[praxstack]

📋 Description

Addresses feedback from a code review of the merged environment/skills work (PRs #34, #35). No Critical issues were found; this fixes the one Important item plus targeted hardening.

• .cursor/environment.json: chain the install with && (npm ci && bash scripts/link-agent-skills.sh) so a failing npm ci short-circuits instead of running the link step unconditionally (fail-fast).
• scripts/link-agent-skills.sh: if a pre-existing real (non-symlink) directory occupies a target, remove it before ln -sfn so a link is never nested inside it. Also corrected the header comment to match the actual install-step wiring.

🔄 Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

✅ Validation

• bash -n scripts/link-agent-skills.sh → OK
• .cursor/environment.json valid; install = "npm ci && bash scripts/link-agent-skills.sh"
• Hardening test: pre-existing real dir at target is replaced by a symlink; idempotent across runs
• npm run lint → 0 errors; npm test → 55/55

📝 Additional Notes

Deferred minor items from the review (latent, no current impact; noted for future): multi-line YAML frontmatter parsing in gen-skills-index.js, a .claude/.agents tree-parity assertion, and multi-collision basename handling in install-agent-skills.sh.

  

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}