fix: replace recursive toString and clone with iterative implementations (CVE-2026-9358)#317
Closed
juanarbol wants to merge 1 commit into
Closed
fix: replace recursive toString and clone with iterative implementations (CVE-2026-9358)#317juanarbol wants to merge 1 commit into
juanarbol wants to merge 1 commit into
Conversation
Deeply nested selector trees (built programmatically or via parsing) could crash Node.js with a RangeError from exceeding the call stack limit. - Container/Root/Pseudo toString() now uses an explicit stack instead of recursive String(child) calls. - cloneNode() now processes the nodes array via a work queue instead of recursing. Adds regression tests for both code paths Refs: CVE-2026-9358
Author
|
Oh, nevermind, closing in favor of #316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deeply nested selector trees (built programmatically or via parsing) could crash Node.js with a RangeError from exceeding the call stack limit.
Container/Root/Pseudo toString() now uses an explicit stack instead of recursive String(child) calls.
cloneNode() now processes the nodes array via a work queue instead of recursing.
Adds regression tests for both code paths
Refs: CVE-2026-9358