[nealrichardson]

Fixes #56.

Problem

The modern ghcr.io/posit-dev/connect image runs startup.sh as PID 1, with no SIGTERM trap and no exec. A shell running as PID 1 ignores SIGTERM, so container.stop() waits out Docker's grace period (10 seconds by default) and then SIGKILLs the container. That happens on every --stop and at the end of every command-mode run. The legacy rstudio/rstudio-connect images don't have this problem, because tini forwards the signal.

Fix

stop_connect_container() runs pkill -TERM -f '^/opt/rstudio-connect/bin/connect( |$)' inside the container and waits up to 10 seconds for the container to exit. If pkill doesn't match, isn't installed, or Connect doesn't exit in time, it falls back to container.stop(timeout=2). This is the stop part of #53, adapted to how with-connect runs Connect without a keep-alive process.

Both stop paths use it: --stop and the cleanup in main(). I also removed an extra container.stop() in wait_for_http_server(), because the finally in main() already stops the container on that path.

Verification

• The pattern matches only the Connect server process, not rserver-monitor or other children. It also matches under Rosetta on Apple Silicon.

• Using throwaway containers on the modern image:

  	time	exit code
  container.stop()	killed after the grace period	137 (SIGKILL)
  stop_connect_container()	0.4 s	0, and Connect logs its own shutdown

  On my machine Docker gave containers a 1-second stop timeout, so the plain stop took about 1.2 s instead of the ~11 s in the issue. The fast stop also means Connect shuts down cleanly instead of being SIGKILLed.

• On the legacy jammy image, signaling Connect directly exits cleanly in 0.27 s.

• Unit tests cover the helper (signaling Connect, pkill not matching or not installed, exec errors, wait timeouts) and both stop paths through main().

Merging with #70

This branch merges cleanly with #69. It has one small conflict with #70 in the finally cleanup: keep #70's try/except warning and call stop_connect_container(container) inside it.

🤖 Generated with Claude Code