fix(ci): build the wasm image directly instead of via the r-wasm reusable workflow - #319
Merged
Merged
Conversation
…able workflow release-file-system-image.yml leaves `remotes = NA` in `rwasm::add_pkg()`, which resolves rwasm's built-in list of webR package forks from GitHub with no PAT. That resolution fails here, surfacing as an opaque `res_one_row_df(): nrow(out) must equal 1` from the container's older pkgdepends. We build only shinyreact, so `remotes = NULL` skips it. Refs #268
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #318. The reusable workflow failed on
r/v0.1.0: itsrwasm::add_pkg()call leavesremotes = NA, which resolves rwasm's built-in list of webR package forks (r-wasm/shiny@webrand friends) from GitHub with no PAT —docker rundoes not forwardGITHUB_TOKENinto the container. The container's older pkgdepends reports the failure as an opaqueres_one_row_df(): nrow(out) must equal 1(r-lib/pkgdepends#462 masks the real error).We build only shinyreact (
dependencies = FALSE, same as the reusable workflow), so the fork preferences are irrelevant andremotes = NULLskips that resolution entirely. Dependencies come from repo.r-wasm.org at runtime.Verified on a scratch branch: the build produces
library.data.gz(113 KB) +library.js.metadata, both now attached to https://github.com/posit-dev/shinyreact/releases/tag/r/v0.1.0.