Skip to content

fix: always show aside title in single-citation popover - #414

Open
gadenbuie wants to merge 2 commits into
mainfrom
fix/412-include-title-in-single-citation-cards
Open

gadenbuie wants to merge 2 commits into
mainfrom
fix/412-include-title-in-single-citation-cards

Conversation

@gadenbuie

@gadenbuie gadenbuie commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #412

Summary

A lone labeled aside previously repeated its title in the popover only when the group held multiple entries or the aside carried a URL. In the single-entry, no-URL case the pill was the only place the title appeared, where CSS truncation can hide most of it. showPopoverLabel in AsideGroup.tsx now shows the popover title whenever the entry has a label, matching the multi-entry popover behavior. Tests in AsideGroup.test.tsx cover the single-entry labeled case, including entries with and without URLs.

image image

A lone labeled aside repeated its title only when the group held
multiple entries or the aside carried a URL. In the single-entry,
no-URL case the pill was the only place the title appeared, where
CSS truncation can hide most of it. Show the title in the popover
whenever the entry has a label, matching the multi-entry popover.
Bundles the aside popover title fix (dced934) into js/dist and copies
the built assets into the R and Python packages.
@gadenbuie
gadenbuie marked this pull request as ready for review September 22, 2026 16:45
@gadenbuie
gadenbuie requested a review from cpsievert September 22, 2026 16:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include title in single citation cards

1 participant