Skip to content

fix: warn when frozen Python violates project requirement - #932

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_927-2133cb147e9d7f44
Nov 6, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_927-2133cb147e9d7f44

Conversation

@tdstein

@tdstein tdstein commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Warn when generated requirements come from a Python interpreter that does not satisfy the project's detected Python requirement, using the same check as preflight.

Evidence

  • Before: manifest generation recorded incompatible Python and requirement versions without a warning.
  • After: focused command tests cover mismatches from .python-version, pyproject.toml, and setup.cfg, as well as compatible and existing requirements cases. Environment, preflight, and metadata tests pass.

Merge Danger

Door: two-way

Blast Radius: deployment and manifest generation warnings

Closes #927

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-06 19:56 UTC

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11121 9862 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/environment.py 94% 🟢
rsconnect/preflight.py 87% 🟢
rsconnect/pyproject.py 98% 🟢
TOTAL 93% 🟢

updated for commit: 1096f22 by action🐍

@tdstein tdstein left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdstein
tdstein enabled auto-merge (squash) November 6, 2026 19:48
@tdstein
tdstein requested a review from joshyam-k November 6, 2026 19:49
@tdstein
tdstein merged commit 658de56 into main Nov 6, 2026
49 of 50 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_927-2133cb147e9d7f44 branch November 6, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy and write-manifest don't warn when the frozen environment doesn't satisfy the Python version requirement

2 participants