Skip to content

Fix editable dependencies inside deployment directories - #931

Merged
tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_926-816562ccaf2332bf
Nov 6, 2026
Merged

tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_926-816562ccaf2332bf

Conversation

@tdstein

@tdstein tdstein commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Editable installs inside a deployment directory were rejected even though their sources can be bundled. Rewrite those paths to relative requirements, including escaped file URLs for paths with spaces, while rejecting outside paths and local editables in single-notebook bundles.

Validation: environment and bundle tests (248 passed); pip and uv compatibility tests (3 passed); Ruff and diff checks.

Closes #926

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-06 19:55 UTC

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11164 9903 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/bundle.py 89% 🟢
rsconnect/subprocesses/inspect_environment.py 93% 🟢
TOTAL 91% 🟢

updated for commit: dc4fe07 by action🐍

tdstein

This comment was marked as outdated.

@tdstein tdstein changed the title fix: bundle editable dependencies inside deployment directory Fix editable dependencies inside deployment directories Nov 6, 2026
@tdstein
tdstein enabled auto-merge (squash) November 6, 2026 19:48
@tdstein
tdstein requested a review from joshyam-k November 6, 2026 19:49
@tdstein
tdstein merged commit 91201e9 into main Nov 6, 2026
52 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_926-816562ccaf2332bf branch November 6, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editable installs inside the deployment directory are rejected as outside it

2 participants