Skip to content

Fix uv lock export for bare document paths - #929

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_922-6a7f36eae5e11184
Nov 6, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_922-6a7f36eae5e11184

Conversation

@tdstein

@tdstein tdstein commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Notebook and Quarto commands fail to export uv.lock when a document is given as a bare filename because uv receives an empty working directory. Resolve the lock path before selecting the export directory so bare and ./ paths both work.

Regression tests cover manifest generation and the deployment environment inspection boundary for both document types, plus lock path variants.

Validation: 120 focused tests passed; Ruff lint and formatting checks passed.

Closes #922

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-06 19:51 UTC

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11114 9874 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/subprocesses/inspect_environment.py 86% 🟢
TOTAL 86% 🟢

updated for commit: a949e59 by action🐍

@tdstein
tdstein enabled auto-merge (squash) November 6, 2026 19:48
@tdstein
tdstein requested a review from joshyam-k November 6, 2026 19:48

@joshyam-k joshyam-k left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could see it being useful to update changelog here too, but also fine if not

@tdstein

tdstein commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

could see it being useful to update changelog here too, but also fine if not

I think I'm going to do a final pass on the changelog prior to release. Just to clean everythign up

@tdstein
tdstein merged commit 3408e18 into main Nov 6, 2026
27 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_922-6a7f36eae5e11184 branch November 6, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notebook and Quarto deploys with -r uv.lock fail for a bare filename (cwd is empty)

2 participants