Repository navigation
fix: support minor Python version overrides - #911
Merged
tdstein merged 13 commits intoNov 6, 2026
Merged
Conversation
|
tdstein
commented
Oct 28, 2026
tdstein
left a comment
tdstein
left a comment
Collaborator
Author
There was a problem hiding this comment.
Address the linting errors:
uv run --group test ruff format --check .
Using CPython 3.12.3 interpreter at: /usr/bin/python3
Creating virtual environment at: .venv
Building rsconnect-python @ file:///home/runner/work/rsconnect-python/rsconnect-python
warning: `build_system.requires = ["uv-build>=0.9.0,<0.13.0"]` does not contain the current uv version 0.13.6
Built rsconnect-python @ file:///home/runner/work/rsconnect-python/rsconnect-python
Installed 94 packages in 204ms
unformatted: File would be reformatted
--> tests/test_main.py:2173:34
|
2172 | [
- "write-manifest", "api", "--entrypoint", "app:app", "--exclude-renv",
- "--override-python-version", version, str(tmp_path),
2173 + "write-manifest",
2174 + "api",
2175 + "--entrypoint",
2176 + "app:app",
2177 + "--exclude-renv",
2178 + "--override-python-version",
2179 + version,
2180 + str(tmp_path),
2181 | ],
|
tdstein
changed the title
tdstein
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
enabled auto-merge (squash)
October 28, 2026 17:14
tdstein
changed the title
tdstein
changed the title
joshyam-k
reviewed
Oct 28, 2026
joshyam-k
left a comment
joshyam-k
left a comment
Contributor
There was a problem hiding this comment.
can we update some integration tests to actually test this? that would make me feel better about the change.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tdstein
changed the title
tdstein
changed the title
tdstein
commented
Oct 29, 2026
tdstein
changed the title
amol-
requested changes
Nov 2, 2026
joshyam-k
approved these changes
Nov 6, 2026
tdstein
changed the title
tdstein
disabled auto-merge
November 6, 2026 17:24
Drop the runtime warning about pre-2025.03.0 Connect servers, which printed even when targeting newer servers. Document the requirement in the --override-python-version help and the changelog instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tdstein
deleted the
symphony/posit-dev_rsconnect-python_901-9943c3d04ec86ed8
branch
November 6, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A major.minor Python override now requests matching patch releases instead of pinning a fabricated
.0release. Full patch overrides remain exact. The manifest retains the local interpreter version for compatibility; Connect versions before 2025.03.0 require a full patch override.Evidence
--override-python-version 3.11produced==3.11.0.==3.11.*; manifest and Connect integration tests cover minor and patch overrides.uv run pytest tests/test_environment.py tests/test_main.py tests/test_validation.py: 243 passed, 12 skipped.just lint: Ruff passes; the recipe ignores existing Pyright errors.Merge Danger
Door: two-way
Blast Radius: Python deployments
Closes #901