Skip to content

fix: report static notebook render failures cleanly - #908

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_897-c252c7539421bbdd
Oct 28, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_897-c252c7539421bbdd

Conversation

@tdstein

@tdstein tdstein commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Convert nbconvert failures into a concise rsconnect error while preserving nbconvert's diagnostic output.
  • Cover malformed notebooks, cell execution errors, and a missing nbconvert installation through the deploy command.

Validation

  • uv run pytest -q tests/test_bundle.py tests/test_main.py (244 passed, 10 skipped)
  • uv run ruff check .
  • uv run ruff format --check .
  • uv build
  • uv run pyright reports repository-wide errors; type checking is advisory in this repository.

Closes #897

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 18:45 UTC

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11019 9683 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/bundle.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 5830c03 by action🐍

@tdstein
tdstein enabled auto-merge (squash) October 28, 2026 17:14
@joshyam-k

Copy link
Copy Markdown
Contributor

Seems like #892 will need some work since this merges first

@tdstein

tdstein commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Seems like #892 will need some work since this merges first

Yeah, I'm going to rework 982 once this stuff lands. That is actually what spawned all of these bug fixes.

@tdstein
tdstein disabled auto-merge October 28, 2026 18:45
@tdstein
tdstein merged commit 8068f06 into main Oct 28, 2026
27 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_897-c252c7539421bbdd branch October 28, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static notebook render failures end in a CalledProcessError traceback and "Internal error"

2 participants