Skip to content

fix: report dangling symlinks during bundling - #907

Merged
tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_898-8f884f9a5e084cc6
Oct 28, 2026
Merged

tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_898-8f884f9a5e084cc6

Conversation

@tdstein

@tdstein tdstein commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Report a clear actionable error when a dangling symlink cannot be checksummed during manifest or bundle creation.
  • Cover dangling project and virtual-environment symlinks, valid symlinks, and CLI error output.

Validation

  • Focused bundle, CLI, and environment tests; Ruff checks and formatting.
  • Previously reran the failed Connect integration job successfully.

Closes #898

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 18:31 UTC

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11028 9689 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/bundle.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 3c79299 by action🐍

@tdstein tdstein left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a CI failure against 2024.03.0. This is a very old version of Connect, and Node support does not exist there.

FAILED tests/test_agent_cli_e2e.py::test_node_preflight_uses_saved_oauth_and_preserves_project_files - AssertionError: assert 'unknown' == 'ok'

It's possible the test needs to be modified to accamodate this state.

@tdstein
tdstein merged commit e2239b8 into main Oct 28, 2026
52 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_898-8f884f9a5e084cc6 branch October 28, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dangling symlink in the project directory crashes bundling with FileNotFoundError

2 participants