Skip to content

Fix missing requirements directory for bare filenames - #906

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_896-92a5279b82e5b1fd
Oct 28, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_896-92a5279b82e5b1fd

Conversation

@tdstein

@tdstein tdstein commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Report . rather than an empty directory when requirements are missing for content in the current directory.
  • Cover notebook manifest and deployment and Quarto deployment with bare, relative, and absolute paths, including custom requirements files.

Validation

  • uv run ruff format --check rsconnect/environment.py tests/test_main.py
  • uv run ruff check rsconnect/environment.py tests/test_main.py
  • uv run pytest tests/test_environment.py tests/test_main.py -q (148 passed, 10 skipped)

Closes #896

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 18:00 UTC

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11019 9694 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/environment.py 91% 🟢
TOTAL 91% 🟢

updated for commit: 8567a56 by action🐍

@tdstein
tdstein enabled auto-merge (squash) October 28, 2026 17:14
@tdstein
tdstein disabled auto-merge October 28, 2026 18:00
@tdstein
tdstein merged commit a58d5ea into main Oct 28, 2026
27 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_896-92a5279b82e5b1fd branch October 28, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing-requirements error shows an empty directory ("does not exist in ''") for a bare notebook filename

2 participants