Skip to content

fix: validate pyproject dependency entries - #904

Merged
tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_895-83d1d3d8e9b02b0b
Oct 28, 2026
Merged

tdstein merged 2 commits into
mainfrom
symphony/posit-dev_rsconnect-python_895-83d1d3d8e9b02b0b

Conversation

@tdstein

@tdstein tdstein commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Reject non-string project.dependencies entries and terminate generated requirements files with a newline.
  • Preserve Python 3.8 compatibility and cover both homogeneous invalid arrays and mixed arrays supported by the active TOML parser.

Validation

  • just test 3.8, just test 3.10, and just test 3.13
  • Focused Python 3.9 dependency and write-manifest tests
  • Ruff lint and formatting checks; git diff --check

Closes #895

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 17:57 UTC

tdstein

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11021 9687 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/subprocesses/inspect_environment.py 90% 🟢
TOTAL 90% 🟢

updated for commit: 9c49d47 by action🐍

@tdstein
tdstein enabled auto-merge (squash) October 28, 2026 17:14
@tdstein
tdstein merged commit 45eba89 into main Oct 28, 2026
52 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_895-83d1d3d8e9b02b0b branch October 28, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-string project.dependencies entries are written verbatim into the generated requirements file

2 participants