Skip to content

Handle malformed pyproject during Python version detection - #903

Merged
tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_893-57d9137c9851dce9
Oct 28, 2026
Merged

tdstein merged 1 commit into
mainfrom
symphony/posit-dev_rsconnect-python_893-57d9137c9851dce9

Conversation

@tdstein

@tdstein tdstein commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Report malformed root pyproject.toml as a user-facing RSConnectException during environment creation, preserving the TOML parser's reason.
  • Cover the environment API and write-manifest CLI when requirements.txt is present.

Validation

  • Focused environment, pyproject, preflight, write-manifest, and deploy tests: 184 passed.
  • Ruff check and format check on changed files; git diff --check.

Closes #893

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-28 17:18 UTC

@github-actions

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11022 9684 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/environment.py 91% 🟢
TOTAL 91% 🟢

updated for commit: efed82c by action🐍

@tdstein
tdstein merged commit 4298319 into main Oct 28, 2026
27 checks passed
@tdstein
tdstein deleted the symphony/posit-dev_rsconnect-python_893-57d9137c9851dce9 branch October 28, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed pyproject.toml crashes with a TOMLDecodeError traceback instead of a clear error

2 participants