Repository navigation
Fix Voilà manifest directory resolution - #890
Merged
tdstein merged 2 commits intoOct 28, 2026
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
enabled auto-merge (squash)
October 27, 2026 21:27
create_python_environment only used app_file for its dirname, so callers had to keep it consistent with directory. Drop the parameter so the inspected directory is stated once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshyam-k
approved these changes
Oct 28, 2026
tdstein
deleted the
symphony/posit-dev_rsconnect-python_886-e1154b51db982ee0
branch
October 28, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_fileparameter fromEnvironment.create_python_environment. It was only used for itsdirname, so callers had to keep it consistent withdirectory; a mismatch is what caused write-manifest voila resolves a directory path without a trailing slash to the working directory #886. Environment inspection now always uses the project directory.Validation
pytest tests: 1743 passed, 14 skipped, 8 failed. The 8 failures are intests/test_quickstart.py::test_quickstart_mode_file_setand also fail without this change.ruff format --checkandruff checkpass.Closes #886
🤖 Generated with Claude Code