Repository navigation
test: deflake test_lonboard_view_state_roundtrips_to_python - #321
Merged
Merged
Conversation
bounding_box() intermittently returns None because the canvas can be re-created while the map finishes initializing (e.g., when the initial view state syncs back to Python). Poll the live DOM for a connected, non-zero-sized canvas instead of relying on a one-shot bounding_box() call after to_be_visible().
cpsievert
marked this pull request as ready for review
October 23, 2026 00:27
cpsievert
added a commit
that referenced
this pull request
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_lonboard_view_state_roundtrips_to_pythonhas been failing intermittently in CI (seen on #306 and #289 in the same day):canvas.bounding_box()returnsNoneright afterexpect(canvas).to_be_visible()passes. The canvas element can be re-created while the map finishes initializing (e.g., when the initial view state syncs back to Python), so the one-shotbounding_box()call can hit a detached or zero-sized element. This replaces it withpage.wait_for_function()that polls the live DOM for a connected, non-zero-sized canvas and returns its rect.Verification
Ran the lonboard Playwright suite locally (
uv run pytest tests/playwright/render_lonboard): all 5 tests pass, and the previously flaky test passed 5/5 repeated runs.