Prompt for content type when detection can't determine one - #4374
Prompt for content type when detection can't determine one#4374nealrichardson wants to merge 2 commits into
Conversation
) When Publisher can't automatically determine a content type for an entrypoint, the New Deployment flow now shows a quick pick of all valid content types instead of silently writing type = "unknown" to the config. Picking a type fills in the same required sections (python/r/quarto) that automatic detection would have set, so the generated configuration is valid immediately. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
getManualContentTypeQuickPicks called inspectManualContentType without relativeDir, so it always defaulted to ".". For an entrypoint in a subdirectory, this dropped the subdirectory from the resulting inspection result's projectDir, which would have written the config/deployment record to the wrong location. Thread relEntryPointDir through the same way getConfigurationInspectionQuickPicks already does. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Claude finished @nealrichardson's task in 1m 31s —— View job Code Review Complete
Overall: This PR looks good to merge. The implementation is clean, well-documented, and follows existing patterns in the codebase. Summary of Changes
Strengths
Minor Observations (not blocking)
No bugs, security issues, or code quality concerns found. Approving this PR. |
|
I tried this locally, and it works, but the contents of the menu, the list of options of app modes, needs some work, so let me iterate on this some more. |
Summary
When Publisher can't detect a content type for an entrypoint, it now prompts you to pick one from the list of valid content types instead of silently writing
type = "unknown"to the config. The chosen type is treated as if it had been detected automatically, including filling in the required[python]/[r]/[quarto]sections.Closes #2833
Closes #2666
Test plan
tsc --noEmiteslint(project-wide, zero warnings)vitest run(full suite, 1991 tests)import fastapi) and confirm the content-type picker appears and produces a valid config