remove OTEL_RESOURCE_ATTRIBUTES hotfix - #301
Open
simonpcouch wants to merge 2 commits into
Open
Conversation
|
Preview deployed to Connect ( Deployed from commit 97e640a. |
|
Preview deployed to Connect ( Deployed from commit 97e640a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66. With
maincommons, trajectory reading works on both dogfood, staging, and connect.posit.it. With this PR, trajectory reading works on dogfood and staging and does not yet work on connect.posit.it—this is expected, as the bug fix hasn't been deployed there yet.Also removes the ellmer/otelsdk internals hack that sets
OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENTand then reestablishes the tracer.log = TRUEcan mostly serve as an "I intend to read logs" flag and then commons can help the user debug.