Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 52.14% 52.28% +0.14%
==========================================
Files 37 37
Lines 6012 6049 +37
Branches 643 648 +5
==========================================
+ Hits 3135 3163 +28
- Misses 2234 2238 +4
- Partials 643 648 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…is also fixed, not just the local case
nevrome
marked this pull request as ready for review
August 9, 2026 13:54
stschiff
approved these changes
Aug 11, 2026
stschiff
left a comment
Member
There was a problem hiding this comment.
OK, went through this. Very nice! Thanks for fixing the nasty encoding bug in addCols. I had to drill a bit deeper to actually find it myself. I was very confused when List.hs had so few changes to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes collected here:
--newContributorsin rectify.trident listwhen additional .janno columns are requested.validate.