Skip to content

Various minor fixes/changes suggested by Thiseas and others - #396

Merged
nevrome merged 11 commits into
masterfrom
thiseas
Aug 11, 2026
Merged

Various minor fixes/changes suggested by Thiseas and others#396
nevrome merged 11 commits into
masterfrom
thiseas

Conversation

@nevrome

@nevrome nevrome commented Jul 21, 2026

Copy link
Copy Markdown
Member

Changes collected here:

  • Made the display of description and source url in the explorer page of the of the server's html API indendent of each other.
  • Made the source column hide when the necessary URL is missing on the archive page.
  • Added a input validation feature that checks line endings of the first (!) row in text files in packages. Only runs when checksums are present, because only then a difference in line endings can lead to unexpected behaviour.
  • Made it possible to give ORCIDs with --newContributors in rectify.
  • Fixed encoding issues in trident list when additional .janno columns are requested.
  • Nicer error messages in case of missing input files in validate.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.26882% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.28%. Comparing base (e9a4f7c) to head (38d4045).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/Core/ServerHTML.hs 0.00% 10 Missing ⚠️
src/Poseidon/Core/Utils.hs 58.82% 3 Missing and 4 partials ⚠️
src/Poseidon/CLI/Trident/List.hs 0.00% 2 Missing and 1 partial ⚠️
src/Poseidon/CLI/Trident/Serve.hs 50.00% 1 Missing ⚠️
src/Poseidon/Core/Contributor.hs 80.00% 0 Missing and 1 partial ⚠️
src/Poseidon/Core/Package.hs 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   52.14%   52.28%   +0.14%     
==========================================
  Files          37       37              
  Lines        6012     6049      +37     
  Branches      643      648       +5     
==========================================
+ Hits         3135     3163      +28     
- Misses       2234     2238       +4     
- Partials      643      648       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nevrome
nevrome requested a review from stschiff August 9, 2026 13:54
@nevrome
nevrome marked this pull request as ready for review August 9, 2026 13:54

@stschiff stschiff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, went through this. Very nice! Thanks for fixing the nasty encoding bug in addCols. I had to drill a bit deeper to actually find it myself. I was very confused when List.hs had so few changes to it.

Comment thread src/Poseidon/Core/Utils.hs
Comment thread test/PoseidonGoldenTests/GoldenTestsRunCommands.hs
@nevrome
nevrome merged commit e07f6c7 into master Aug 11, 2026
2 checks passed
@nevrome
nevrome deleted the thiseas branch August 11, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants