Fix trailing MSSQL GO batch separators - #69
Open
dvasdekis wants to merge 1 commit into
Open
Conversation
dvasdekis
marked this pull request as ready for review
September 1, 2026 04:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #68.
The existing MSSQL
GOrange splitter did not handle a separator line that extended beyond a semicolon-delimited range. A trailingGOcould therefore remain as a standalone range and be sent to the SQL parser, producingPARSE_ERROR.This change treats overlapping separator ranges as batch boundaries and clips them to the current statement range. It preserves the existing behavior for intermediate separators while removing trailing and repeated separators from analysis input.
Changes
GOrange handling.GOinside strings, comments, and bracket-quoted identifiers.analyze_sql_jsonandsplit_statements_json.Validation
Passed locally:
cargo fmt --all -- --checkcargo test -p flowscope-core mssql_ --lockedcargo test -p flowscope-wasm --test analysis --lockedcargo test --workspace --lockedcargo clippy --workspace --locked -- -D warningsgit diff --checkThe browser integration test was not run in this environment because
wasm-packand Chromium are unavailable. It can be run locally with:Or, if
justis installed:The regression input is:
Expected result: two analyzed statements and no
PARSE_ERRORissues.