Repository navigation
fix(time-tracking): count every calendar day toward a lock - #228
Merged
Merged
Conversation
Empty days were treated as having nothing to lock, so a week or month with only an open weekend left looked finished. Kleer reports that week as not locked, and production has a status for every past day, so a period is now done only when all its days are locked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ponbac
marked this pull request as ready for review
October 30, 2026 22:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The sign-off panel treated days with no time and no schedule as having nothing to lock. A week or month with only an empty weekend left open therefore looked finished, and nothing asked anyone to close it.
Kleer disagrees. With Saturday 31 Oct open, its week page reports
26–31 Octas not locked. Production also has a status for every past day checked, 1 Aug to 30 Oct, empty weekends included, so the old rule came from gaps in Kleer's test environment rather than from real behaviour.Kleer's month page is less strict: it still showed October as
Godkändwith that Saturday open. Toki follows the stricter week view.How
A period now counts as done only when every calendar day in it is locked. If only an empty weekend is left, the panel asks for it and shows rows for those days. While there is still work to review, empty days stay hidden to keep the list short. Deadlines are unchanged and still follow the last scheduled day.
Limitations
Checks
just check-allpassed before a final comment and dead-field cleanup. After the cleanup,bunx tsc --noEmitandbun lintpassed andbun run testgave 339 passed, 0 failed.🤖 Generated with Claude Code