Skip to content

fix(time-tracking): count every calendar day toward a lock - #228

Merged
ponbac merged 1 commit into
masterfrom
fix/lock-every-calendar-day
Oct 30, 2026
Merged

ponbac merged 1 commit into
masterfrom
fix/lock-every-calendar-day

Conversation

@ponbac

@ponbac ponbac commented Oct 30, 2026

Copy link
Copy Markdown
Owner

What and why

The sign-off panel treated days with no time and no schedule as having nothing to lock. A week or month with only an empty weekend left open therefore looked finished, and nothing asked anyone to close it.

Kleer disagrees. With Saturday 31 Oct open, its week page reports 26–31 Oct as not locked. Production also has a status for every past day checked, 1 Aug to 30 Oct, empty weekends included, so the old rule came from gaps in Kleer's test environment rather than from real behaviour.

Kleer's month page is less strict: it still showed October as Godkänd with that Saturday open. Toki follows the stricter week view.

How

A period now counts as done only when every calendar day in it is locked. If only an empty weekend is left, the panel asks for it and shows rows for those days. While there is still work to review, empty days stay hidden to keep the list short. Deadlines are unchanged and still follow the last scheduled day.

Limitations

  • Anyone with an open empty day from last month onward may now see it as due or overdue. One lock clears it.
  • Existing limitation, unchanged here: the check looks back to the first of last month, so an older open day stops being reported once it leaves that window.

Checks

  • Automated: just check-all passed before a final comment and dead-field cleanup. After the cleanup, bunx tsc --noEmit and bun lint passed and bun run test gave 339 passed, 0 failed.
  • New test: an open empty weekend keeps week 44 and October due. An independent reviewer confirmed it fails against the old rule.
  • Manual: in a mock of the built app dated 30 Oct with Mon-Fri locked, the panel asked for the week and month with rows for Sat 31 and Sun 1, and one click reached "Locked through Sun 1 Nov".
  • Not done: no lock has been run against production Kleer from this change.

🤖 Generated with Claude Code

Empty days were treated as having nothing to lock, so a week or month with only an open weekend left looked finished. Kleer reports that week as not locked, and production has a status for every past day, so a period is now done only when all its days are locked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ponbac
ponbac marked this pull request as ready for review October 30, 2026 22:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T22:23:09.162625Z 341584c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ponbac
ponbac merged commit e1c8326 into master Oct 30, 2026
3 checks passed
@ponbac
ponbac deleted the fix/lock-every-calendar-day branch October 30, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant