Skip to content

Dynamic-Announcements - upgrade to SPFx 1.23 - #232

Open
a1mery wants to merge 3 commits into
pnp:mainfrom
a1mery:Dynamic-Announcements
Open

Dynamic-Announcements - upgrade to SPFx 1.23#232
a1mery wants to merge 3 commits into
pnp:mainfrom
a1mery:Dynamic-Announcements

Conversation

@a1mery

@a1mery a1mery commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
Q A
New feature? yes

What's in this Pull Request?

Upgrade sample to SPFx 1.23.0

@anoopt

anoopt commented Aug 5, 2026

Copy link
Copy Markdown
Member

Thanks for the SPFx 1.23 upgrade! The automated build check failed — full logs here: https://github.com/pnp/sp-dev-fx-aces/actions/runs/31055478978

The failure happens during heft package-solution --production, before any TypeScript/webpack step:

Error: Cannot find module 'ajv/dist/core'
Require stack:
- node_modules/ajv-draft-04/dist/index.js
- node_modules/@rushstack/heft/node_modules/@rushstack/node-core-library/lib-commonjs/JsonSchema.js
...

This looks like an ajv version mismatch — ajv-draft-04 (pulled in transitively by @rushstack/node-core-library) expects ajv v8's ajv/dist/core export, but the installed dependency tree doesn't have it, most likely due to a stale/inconsistent package-lock.json.

Could you try regenerating the lockfile and re-pushing?

rm -rf node_modules package-lock.json
npm install
npm run build

and commit the updated package-lock.json if that resolves it locally. Happy to take another look once it's pushed.

@a1mery

a1mery commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@anoopt many thanks for your review! I've updated the package-lock.json.
It solved the issue locally ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants